Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign index pages #6497

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Redesign index pages #6497

merged 4 commits into from
Mar 15, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 14, 2024

Aligns the index page design with the error page changes in #6496.

Overall I'm aiming for a cleaner and more neutral look for the default pages. The previous version was really nice particularly with the theme toggle etc. but pulling in a whole design toolkit for a simple static page seemed like a lot and with the banner it felt quite busy.

Screenshot 2024-03-14 at 21 46 20

Compared to the old version:

Screenshot 2024-03-14 at 21 47 21

@ahuang11
Copy link
Contributor

ahuang11 commented Mar 14, 2024

Do app previews support descriptions, or just name?

Also, would it make sense to swap the location of search and Running 7 applications?

@philippjfr
Copy link
Member Author

Do app previews support descriptions, or just name?

To be precise they support neither, these are simply the app filenames after being transformed with name.replace("_", " ").title()

Also, would it make sense to swap the location of search and Running 7 applications?

Think I prefer this.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.02%. Comparing base (aea6cdf) to head (fe7990f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6497      +/-   ##
==========================================
- Coverage   82.08%   82.02%   -0.06%     
==========================================
  Files         314      314              
  Lines       46358    46358              
==========================================
- Hits        38052    38026      -26     
- Misses       8306     8332      +26     
Flag Coverage Δ
ui-tests 36.44% <ø> (-0.23%) ⬇️
unitexamples-tests 71.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 6a64623 into main Mar 15, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the index_page_redesign branch March 15, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants