-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SVG Pane #85
Added SVG Pane #85
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 91.48% 91.55% +0.06%
==========================================
Files 23 23
Lines 3537 3577 +40
==========================================
+ Hits 3236 3275 +39
- Misses 301 302 +1
Continue to review full report at Codecov.
|
Have you tested networkx, which generates graphviz objects that have |
I tested shapely which has a |
Not sure there is anything we can do about it tbh, there is simply no reliable way to determine the size or aspect ratio of the svg ahead of time. |
Not sure what you mean by "ahead of time"; the SVG is static once the Pane is instantiated in this case, right? |
By ahead of time I mean before it is rendered into the browser's DOM. |
Ah. There might be some Python libraries that could at least return the aspect ratio without rendering it, and probably a bounding box, though of course the browser might not respect that. But not something to work on now... |
Adds an SVG pane, unlike other image types the size and/or aspect ratio of the SVG cannot be easily computed ahead of time, but it still seems default to its native size unless explicitly overridden.