Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-level expand Param subobject #965

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Conversation

philippjfr
Copy link
Member

Fixes #630

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #965 into master will decrease coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
- Coverage   85.33%   85.33%   -0.01%     
==========================================
  Files          96       96              
  Lines       10747    10752       +5     
==========================================
+ Hits         9171     9175       +4     
- Misses       1576     1577       +1
Impacted Files Coverage Δ
panel/param.py 90.53% <100%> (-0.05%) ⬇️
panel/util.py 92.24% <85.71%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863293f...85c993b. Read the comment docs.

@philippjfr philippjfr merged commit 26dab76 into master Jan 20, 2020
@philippjfr philippjfr deleted the param_subobject_fix branch January 23, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Param subjobject doesnot close when changing object
1 participant