Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify API for Parameter validation #300

Closed
philippjfr opened this issue Nov 5, 2018 · 1 comment
Closed

Unify API for Parameter validation #300

philippjfr opened this issue Nov 5, 2018 · 1 comment
Labels
type-feature Feature request

Comments

@philippjfr
Copy link
Member

Different parameters have a variety of different methods which perform validation, e.g. things like _check_value, _checkBounds, _check, which are called inside the set methods. This makes it impossible for external code to use the parameter validation, e.g. to perform validation of the output on output methods (see #299). I would propose that each Parameter type should have a public validate method, which performs all the applicable validation calling the various current private methods if necessary.

@philippjfr philippjfr added the type-feature Feature request label Nov 5, 2018
@jbednar
Copy link
Member

jbednar commented Nov 5, 2018

Sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants