Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled cythonizing of param modules if Cython is available #122

Merged
merged 2 commits into from
Apr 1, 2016

Conversation

philippjfr
Copy link
Member

This small PR enables cythonizing for the param __init__, parameterized and version modules. The IPython module has too much magic in it to be supported. Overall this already provides roughly a 50% speedup when creating new parameterized objects (measured by creating 20k HoloViews Images). In future we could go further and actually rewrite some parts of param as actual Cython, but I suspect that may not be worth it given the decent speedup without it and that most of the remaining time is spent deep copying default parameter values, which can in some cases be avoided by setting instantiate to False on a parameter.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.087% when pulling ceb515c on cythonize into 919a86b on master.

@philippjfr
Copy link
Member Author

Seems Python 3.2 isn't supported by the coverage tool anymore so it's failing. Will have to decide whether we should drop support for 3.2 as well.

@jbednar
Copy link
Member

jbednar commented Mar 29, 2016

I think we can safely drop support for Python 3.2 from the latest Param release, or at least stop testing it.

@jbednar
Copy link
Member

jbednar commented Mar 29, 2016

I'm happy for this to be merged.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 69.942% when pulling 0f37d81 on cythonize into 919a86b on master.

@philippjfr
Copy link
Member Author

Removed Python 3.2, tests are now passing. Ready to merge whenever.

@jbednar jbednar merged commit 1f94abc into master Apr 1, 2016
@jbednar jbednar deleted the cythonize branch April 1, 2016 14:23
@jbednar jbednar mentioned this pull request Dec 15, 2021
@jbednar jbednar mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants