Dependencies: support more pythons and begin storing dependency info in more convenient way #254
Conversation
ceball
commented
Aug 28, 2018
ceball
commented
- Support python 2.7 and python3 <3.6
- Keep list of watched methods on class (avoids having to search all attributes at instantiation time)
(Includes restoring more explicit args for depends().)
…ibutes at instantiation time).
|
This looks great, ready to merge? |
|
yes (the TODOs are part of the overall PR; will turn them into issues when that PR is merged) |
|
|
||
| # TODO regarding _attrib_name, _owner: what if someone re-uses | ||
| # a parameter object across different classes? we should raise | ||
| # an error if attrib name,owner already set |
There was a problem hiding this comment.
Raising an error sounds good, and the message could tell people how to avoid the message (by cloning the Parameter object somehow before using it in a new class).
I'm trying to figure out how to make it reasonable to add an _owner_instance slot, but it ties my brain in knots. Basically, I want to be able to ask a Parameterized instance for an object that has all the information in the Parameter, plus a pointer to the actual instance so that the value can be accessed. Yet there's only one Parameter object per class, not per instance, so I guess it would have to be a copy of the Parameter object? And then it wouldn't be the one that actually applies to this object. So I guess that before having _owner_instance, we'd first have to set up allowing a local instance copy of the Parameter to override the class's Parameter, at which point the real Parameter just for this instance could be returned with _owner_instance filled in?
