Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing positional default argument for ClassSelector subclasses #296

Merged
merged 2 commits into from Oct 12, 2018
Merged

Allowing positional default argument for ClassSelector subclasses #296

merged 2 commits into from Oct 12, 2018

Conversation

jlstevens
Copy link
Contributor

This PR should help make parameters that subclass ClassSelector to specific types easier to use. Addresses the issues raised in #292.

@coveralls
Copy link

coveralls commented Oct 12, 2018 •
edited

Coverage Status

Coverage remained the same at 76.713% when pulling 1268725 on parameter_positional_arg into fb8601a on master.

@philippjfr
Copy link
Member

Looks good.

@philippjfr philippjfr merged commit d175211 into master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlstevens @coveralls @philippjfr