Fixed Path to allow folders, as already documented #495
Conversation
| @@ -1628,45 +1628,39 @@ class resolve_path(ParameterizedFunction): | |||
| Prepended to a non-relative path, in order, until a file is | |||
| found.""") | |||
|
|
|||
| path_to_file = Boolean(default=True, pickle_default_value=False, doc=""" | |||
| path_to_file = Boolean(default=True, pickle_default_value=False, | |||
| allow_None=True, doc=""" | |||
| String specifying whether the path refers to a 'File' or a 'Folder'.""") | |||
There was a problem hiding this comment.
I was wondering how it could be anything other than True or False but looking at the code I see that None means either a file or a directory. I'll clarify this docstring further in a small PR.
Minor nitpick but I associate 'folder' with the Windows world while I consider 'directory' to be the proper platform-independent terminology. Probably not worth updating as everyone knows what you mean!
There was a problem hiding this comment.
Clarified docstring in #507. I won't mark this as resolved in case you have any opinion on 'Folder' versus 'Directory'.
There was a problem hiding this comment.
Seems like the docstring is still confusing as it is a boolean, not a string as claimed. Thanks for the None clarification. I agree with your preference for "directory" over "folder", but I am just following the existing param.Filename and param.Foldername terminology.
Path is documented as accepting both files and folders (directories), but it was only accepting files. Fixed to make Path check only that the path exists, not whether it is a file or folder. Also simplified the logic overall. Marked API since the behavior has apparently never matched the documented API; now it should match the previously documented API.