Fix watchers support when the Parameterized instance is falsey #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoxbro
reviewed
Jun 21, 2023
philippjfr
reviewed
Jun 22, 2023
philippjfr
reviewed
Jun 22, 2023
philippjfr
reviewed
Jun 22, 2023
philippjfr
reviewed
Jun 22, 2023
|
Minor, nitpicky comments. |
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747
inst or clswas used to selectclswheninstwas None, except that this fails wheninstis not None andinstis falsey evaluates, as in the example reported in the issue where__len__is defined on a Parameterized class and returns0. This PR fixes a few occurrences of this bug.