New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace .rx.resolve and .rx.set_input with .rx.value property #856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this really streamlines and clarifies usage. Thanks for making it happen!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes that's a great API improvement, thanks @jbednar for making that suggestion, bye bye set_input
and resolve
!
Co-authored-by: James A. Bednar <jbednar@continuum.io>
Overall this seems much cleaner. Some consequences:
(rx(1) + 1).value = 2
is invalid. This was always what was confusing and made naming this difficult..rx.value +=
) and other arithmetic/boolean assignment operators