Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that .param.update context manager restore refs #915

Merged
merged 3 commits into from Mar 4, 2024
Merged

Ensure that .param.update context manager restore refs #915

merged 3 commits into from Mar 4, 2024

Conversation

philippjfr
Copy link
Member

This PR does two things:

  1. Ensures that .param.update restores the references when exiting the context
  2. Allows .param.update to accept an argument AND kwargs, just like dict.update.

Fixes #914

Hoxbro
Hoxbro reviewed Mar 4, 2024
View reviewed changes
param/parameterized.py Outdated Show resolved Hide resolved
param/parameterized.py Outdated Show resolved Hide resolved
tests/testrefs.py Show resolved Hide resolved
@philippjfr philippjfr merged commit ce3d23c into main Mar 4, 2024
10 checks passed
@philippjfr philippjfr deleted the update_restore_refs branch March 4, 2024 18:07
@philippjfr philippjfr added this to the 2.1.0 milestone Mar 4, 2024
@philippjfr philippjfr mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoxbro Hoxbro Hoxbro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Context manager .param.update should restore references
2 participants
@philippjfr @Hoxbro