Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid overeager root invalidation on rx #919

Merged
merged 2 commits into from Mar 13, 2024
Merged

Avoid overeager root invalidation on rx #919

merged 2 commits into from Mar 13, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr added this to the 2.1.0 milestone Mar 13, 2024
@philippjfr philippjfr requested a review from maximlt March 13, 2024 08:56
philippjfr
philippjfr commented Mar 13, 2024
View reviewed changes
param/reactive.py
@@ -790,6 +792,7 @@ def _resolve(self):
if obj is Skip:
raise Skip
except Skip:
self._dirty = False
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically unrelated and just an oversight.

maximlt
maximlt approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@maximlt maximlt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a cosmetic change to make the test a little easier to understand. Other than that, LGTM. I'll merge when the test suite passes.

@maximlt maximlt merged commit c6b0f7b into main Mar 13, 2024
10 checks passed
@maximlt maximlt deleted the root_invalidation_fix branch March 13, 2024 10:02
@philippjfr philippjfr mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximlt maximlt maximlt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philippjfr @maximlt