Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pi hole summary integration #521

Merged
merged 17 commits into from
May 26, 2024
Merged

feat: add pi hole summary integration #521

merged 17 commits into from
May 26, 2024

Conversation

Meierschlumpf
Copy link
Member

@Meierschlumpf Meierschlumpf commented May 18, 2024 •
edited


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

image

@Meierschlumpf Meierschlumpf added the enhancement New feature or request label May 18, 2024
@Meierschlumpf Meierschlumpf self-assigned this May 18, 2024
@Meierschlumpf Meierschlumpf added this to the 1.0.0-alpha.1 milestone May 19, 2024
@Meierschlumpf Meierschlumpf marked this pull request as ready for review May 19, 2024 13:09
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner May 19, 2024 13:09
ajnart
ajnart previously requested changes May 19, 2024
View reviewed changes
apps/nextjs/src/components/board/items/item-actions.tsx Show resolved Hide resolved
apps/nextjs/src/components/board/items/item-actions.tsx Outdated Show resolved Hide resolved
apps/nextjs/src/components/board/sections/content.tsx Show resolved Hide resolved
packages/api/src/middlewares/integration.ts Outdated Show resolved Hide resolved
packages/api/src/middlewares/integration.ts Outdated Show resolved Hide resolved
packages/widgets/src/_inputs/widget-select-input.tsx Show resolved Hide resolved
packages/widgets/src/dns-hole/summary/component.tsx Show resolved Hide resolved
packages/widgets/src/dns-hole/summary/component.tsx Outdated Show resolved Hide resolved
packages/widgets/src/dns-hole/summary/component.tsx Show resolved Hide resolved
packages/widgets/src/dns-hole/summary/component.tsx Outdated Show resolved Hide resolved
manuel-rw
manuel-rw requested changes May 19, 2024
View reviewed changes
packages/api/src/middlewares/integration.ts Outdated Show resolved Hide resolved
packages/api/src/middlewares/integration.ts Show resolved Hide resolved
packages/api/src/router/integration.ts Outdated Show resolved Hide resolved
packages/api/src/router/widgets/dns-hole.ts Outdated Show resolved Hide resolved
packages/common/src/number.ts Show resolved Hide resolved
packages/integrations/package.json Show resolved Hide resolved
manuel-rw
manuel-rw previously approved these changes May 20, 2024
View reviewed changes
manuel-rw
manuel-rw previously approved these changes May 25, 2024
View reviewed changes
@Meierschlumpf
Copy link
Member Author

As it was approved I'm gonna merge it

@Meierschlumpf Meierschlumpf merged commit d57b771 into dev May 26, 2024
8 checks passed
@Meierschlumpf Meierschlumpf deleted the pi-hole-summary branch May 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-rw manuel-rw manuel-rw left review comments

@ajnart ajnart Awaiting requested review from ajnart

Assignees

@Meierschlumpf Meierschlumpf

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Meierschlumpf @manuel-rw @ajnart