Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for development and testing #822

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

emontnemery
Copy link
Collaborator

No description provided.

Copy link
Collaborator Author

@emontnemery emontnemery Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just remove this file and move this to requirements-test.txt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements files normally separate the requirements based on where they are needed. This can be useful if different test environments need different requirements.

If that isn't needed, yes then all the development requirements can be in one list somewhere. I'd say it depends on how you test and how you configure CI.

Comment on lines +1 to +3
casttube==0.2.1
protobuf==4.25.2
zeroconf==0.131.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to pin to latest or to minimum required version when testing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For development, the idea is to pin strictly to the latest working versions. For production, the idea is to require a minimum version as the oldest working version.

Depending on the situation a maximum version can also be added for production requirements (normally the next major version). Production requirements should be as forgiving as possible.

@emontnemery emontnemery merged commit f5f0e23 into master Feb 7, 2024
1 check passed
@emontnemery emontnemery deleted the update_requirements branch February 7, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants