Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging in example scripts #839

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Improve logging in example scripts #839

merged 2 commits into from
Feb 13, 2024

Conversation

emontnemery
Copy link
Collaborator

Improve logging in example scripts:

  • Enable print of Python deprecation warnings etc.
  • Add a separate flag to control log level of discovery
  • Prefix log messages with timestamp and thread name

MartinHjelmare
MartinHjelmare approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of copy paste in the argparse setup of the examples. Maybe have some helper for that?

@emontnemery emontnemery merged commit cdd5e29 into master Feb 13, 2024
1 check passed
@emontnemery emontnemery deleted the examples_improve_logging branch February 13, 2024 14:06
@emontnemery
Copy link
Collaborator Author

There's a lot of copy paste in the argparse setup of the examples. Maybe have some helper for that?

Fixed in #841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emontnemery @MartinHjelmare