Type hint gateway

[ggravlingen]

No description provided.

[ggravlingen]

I believe this constant might need some consideration when we've sorted out type hints on the Gateway class:

pytradfri/pytradfri/command.py

Line 7 in a979ed1

TypeProcessResultCb = Optional[Callable[[Any], Optional[str]]]

[MartinHjelmare]

I believe this constant might need some consideration when we've sorted out type hints on the Gateway class:

pytradfri/pytradfri/command.py

Line 7 in a979ed1

TypeProcessResultCb = Optional[Callable[[Any], Optional[str]]]

We can change it to return Optional[Any] for now. I have some ideas how we can improve that later but that's for when we want to improve typing in the command.py module.

[ggravlingen]

I believe this constant might need some consideration when we've sorted out type hints on the Gateway class:

pytradfri/pytradfri/command.py

Line 7 in a979ed1

TypeProcessResultCb = Optional[Callable[[Any], Optional[str]]]

We can change it to return Optional[Any] for now. I have some ideas how we can improve that later but that's for when we want to improve typing in the command.py module.

I ended up doing the same with the data argument. as it either should be a dict[str, Any], str or None.

[ggravlingen]

Would you oppose if we deprecated moods and smart tasks? I for one don't use them and don't really feel they're worth maintaining. For users who need those features, we could point to Home Assistant.

[MartinHjelmare]

I think the library should represent the tradfri api as close as possible. I don't think we should remove it.

[MartinHjelmare]

Are you planning to type the rest of the gateway module in this PR?

[ggravlingen]

Are you planning to type the rest of the gateway module in this PR?

No, the rest of the file will be a follow-up PR. Felt that was a bit easier to comprehend.

[ggravlingen]

I hadn't planned on touching command.py as it looks to be strictly typed already. Do you want to add your ideas to the file yourself?

[MartinHjelmare]

Yeah, I'll look at that separately. 👍

[MartinHjelmare]

Nice!