Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce strict typing #461

Merged
merged 7 commits into from
Mar 16, 2022
Merged

Enforce strict typing #461

merged 7 commits into from
Mar 16, 2022

Conversation

ggravlingen
Copy link
Member

No description provided.

@ggravlingen
Copy link
Member Author

pytradfri/pytradfri/api/aiocoap_api.py

Line 56 in 3f8573f

self._protocol: asyncio.Task | None = None

What should be the type hint here? In a previous PR, you wrote The Task should be typed with its result value. but I don't quite understand what you mean here.

@ggravlingen
Copy link
Member Author

When this PR is merged, I believe we only have the libcoap-file to go before it's fully typed?

@ggravlingen
Copy link
Member Author

Should we also add type hints to __main__.py?

@MartinHjelmare
Copy link
Contributor

Should we also add type hints to __main__.py?

Yes, we should.

@ggravlingen @MartinHjelmare
Update pytradfri/command.py
7331800 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@ggravlingen
Copy link
Member Author

Should we also add type hints to __main__.py?

Yes, we should.

Great, I’ll look into that.

MartinHjelmare
MartinHjelmare reviewed Mar 15, 2022
View reviewed changes
pytradfri/util.py Outdated Show resolved Hide resolved
pytradfri/util.py Outdated Show resolved Hide resolved
@ggravlingen @MartinHjelmare
Apply suggestions from code review
446a812 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@MartinHjelmare
Copy link
Contributor

The api task returns a Context instance.

@ggravlingen
Copy link
Member Author

I made a change (added Context as return type) after your approval so I won't merge. Please do if the change was acceptable.

MartinHjelmare
MartinHjelmare approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 65f211d into master Mar 16, 2022
@MartinHjelmare MartinHjelmare deleted the enforce-strict-typing branch March 16, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggravlingen @MartinHjelmare