Include URI for device identification #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When receiving a call parse the SIP URI from the Contact or From header to use for identifying a device. Using the URI will make it possible to distinguish between multiple endpoints calling through a centralized server (such as Asterisk) which would otherwise appear to come from the same IP address. Keeping track of the Contact header URI will also make it possible to send outbound calls to the device using the correct URI.
balloob
reviewed
Jul 3, 2024
Comment on lines
+87
to
+91
| if (headers.get('contact') is not None): | ||
| caller_uri, caller_name = self._parse_uri_header(headers.get('contact')) | ||
| # We can try using the From header as a fallback | ||
| elif (headers.get('from') is not None): | ||
| caller_uri, caller_name = self._parse_uri_header(headers.get('from')) |
There was a problem hiding this comment.
Great opportunity to leverage the walrus
Suggested change
| if (headers.get('contact') is not None): | |
| caller_uri, caller_name = self._parse_uri_header(headers.get('contact')) | |
| # We can try using the From header as a fallback | |
| elif (headers.get('from') is not None): | |
| caller_uri, caller_name = self._parse_uri_header(headers.get('from')) | |
| if contact_header := headers.get('contact'): | |
| caller_uri, caller_name = self._parse_uri_header(contact_header) | |
| # We can try using the From header as a fallback | |
| elif from_header := headers.get('from'): | |
| caller_uri, caller_name = self._parse_uri_header(from_header) |
balloob
reviewed
Jul 3, 2024
| @@ -203,6 +229,26 @@ def answer( | |||
| server_rtp_port, | |||
| ) | |||
|
|
|||
| def _parse_uri_header( | |||
| header: str | |||
There was a problem hiding this comment.
All methods shuold start with self. The test passed but the code wasn't working. I fixed it in 4d08d66
|
I'll admit python is a second language for me, so thank you for the feedback. With this change merged we might want to reopen https://github.com/home-assistant/core/pull/111050/files for the associated changes in HA, although it needs to be updated for the change to using the entire URI rather than parsing the individual parts like I was doing originally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving a call parse the SIP URI from the Contact or From header to use for identifying a device. Using the URI will make it possible to distinguish between multiple endpoints calling through a centralized server (such as Asterisk) which would otherwise appear to come from the same IP address. Keeping track of the Contact header URI will also make it possible to send outbound calls to the device using the correct URI.