Show settings chip while loading Wear app #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #2850: the settings chip is now visible in the Wear app while loading, in addition to when the app is ready or loading failed.
Screenshots
The aim is to have settings accessible, but not as a primary action. I have added an artificial delay to loading data for these videos.
With a favorite:
wear-settings-favorite.mp4
Without favorites:
wear-settings-no-favorite.mp4
If you open the settings while the app is still loading, favorite editing is disabled to prevent the app showing an empty list (all other settings should be fine while still loading):
Link to pull request in Documentation repository
n/a
Any other notes