Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move vehicle service to main to allow for minimal Automotive build #3570

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

jpelgrom
Copy link
Member

@jpelgrom jpelgrom commented Jun 6, 2023

Summary

Untangling the Automotive build so we can do a build for devices without GAS as well...

  • Move the vehicle package from full to main so it is included in the minimal build as well, to allow for a minimal Automotive build
  • Adjust dependencies from full to any version (checked: the androidx.car dependencies do not have a dependency on any GMS libraries)
  • Move Automotive CarAppActivity + service + metadata to main manifest; not moved in app module because it is only used for Android Auto there
  • Adjust GitHub Actions to include minimal Automotive APK

Closes #3545: full only dependency now works, deduplication included in this PR.

Screenshots

Minimal automotive build running on an Android Automotive emulator:
Settings screen on an Android Automotive emulator with "LOCAL-minimal" version visible

Link to pull request in Documentation repository

n/a

Any other notes

 - Move the vehicle package from full to main so it is included in the minimal build as well, to allow for a minimal Automotive build
 - Adjust dependencies from full to any version (checked: the androidx.car dependency does not have a dependency on any GMS libraries)
 - Move Automotive CarAppActivity + service + metadata to main manifest; not moved in app module because it is only used for Android Auto there
 - Adjust GitHub Actions to include minimal Automotive APK
@jpelgrom jpelgrom changed the title Move vehicle service to minimal to allow for minimal Automotive build Move vehicle service to main to allow for minimal Automotive build Jun 6, 2023
Copy link
Member

@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@JBassett JBassett merged commit e8fae5d into home-assistant:master Jun 19, 2023
@jpelgrom jpelgrom deleted the minimal-automotive branch June 19, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants