Make volume sensors update instantly by subscribing to a broadcast #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshokouhi
reviewed
Jan 26, 2024
app/src/main/java/io/homeassistant/companion/android/sensors/SensorReceiver.kt
Outdated
Show resolved
Hide resolved
… sensors to the corresponding Intent action key
|
we should do a docs change for this PR as well to mention the sensors will update instantly in the beta. Currently we mention the volume sensors follow the normal update schedule. https://companion.home-assistant.io/docs/core/sensors#audio-sensors other than that functionality looks good to me :) after this PR we should probably look at the other intents that impact more than 1 sensor and add them to the list :) |
JBassett
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Audio volume sensors weren't updating instantly, so a new broadcast Intent subscription has been introduced in this PR to improve this.
How I tested these changes:
Enabled all audio-related sensors, and tried modifying the volume on the device several times, and the new values were reflected nearly instantly on the server. I did this testing for both the Android and Wear OS apps.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1025
Any other notes
The broadcast is
android.media.VOLUME_CHANGED_ACTION, and it is undocumented. No official Android documentation mentions it.