Add option to update camera & template tile when 'in view' #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the tile enter callback to request an update to the tile once it enters the view. Considering that this callback exists it's probably safe to assume an update that is requested in this callback won't be throttled (at least it appears to work during testing). - Minor edit to the refresh interval picker to ensure strings that are more than one line look a bit nicer.
JBassett
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #4007: use the
onTileEnterEventcallback to request an update to the tile once it enters the view. Considering that this callback exists it's probably safe to assume an update that is requested in this callback won't be throttled (at least it appears to work during testing).Includes a minor edit to the refresh interval picker to ensure strings that are more than one line look a bit nicer - originally the string I used was 2 lines but I made it shorter to fit in one instead.
Screenshots
Setting:
Demo video:
PXL_20240202_203035614.TS.-.Trim.mp4
('On view' was changed to 'In view' after taking the screenshot and video)
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#1029
Any other notes