Can not add two secure instances of Elk M1 when using TLS 1.2 #81516

yestrdave · 2022-11-03T23:03:54Z

The problem

I have two Elk M1 Golds. I can add one device secured and one non secured into HA with no issue. If two secured devices are to attempted to be added, the first secured device will add and the second will yield the following message “An ElkM1 with this address is already configured”

Home Assistant 2022.11.1
Supervisor 2022.10.2
Operating System 9.3
Frontend 20221102.1 - latest

What version of Home Assistant Core has the issue?

2022.11.1

What was the last working version of Home Assistant Core?

unknown

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Elk M1

Link to integration documentation on our website

https://www.home-assistant.io/integrations/elkm1

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

I have also tried switching the device order on another test environment and it yielded the same result.

Additional information

I will be happy to provide additional information. Just not sure on this one.

home-assistant · 2022-11-03T23:03:59Z

Hey there @gwww, @bdraco, mind taking a look at this issue as it has been labeled with an integration (elkm1) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of elkm1 can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Change the title of the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign elkm1 Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

elkm1 documentation
elkm1 source
_{^{(message by IssueLinks)}}

yestrdave · 2022-11-03T23:06:41Z

Elk RP settings

gwww · 2022-11-03T23:17:37Z

Well that seems like a bug! Based on the image it looks like you are using the discovered workflow. Could you try adding them not using the discovered devices and see what happens.

yestrdave · 2022-11-03T23:22:01Z

If you mean add integration select Elk select IP then it does the same thing

gwww · 2022-11-03T23:30:06Z

Can you supply a debug log. Add the following to your configuration.yaml:

logs:
    homeassistant.components.elkm1: debug

yestrdave · 2022-11-04T00:03:57Z

Integration error: logs - Integration 'logs' not found.

bdraco · 2022-11-04T00:09:33Z

Just a tiny typo

logger:
    homeassistant.components.elkm1: debug

https://www.home-assistant.io/integrations/logger/

yestrdave · 2022-11-04T00:11:49Z

Invalid config for [logger]: [homeassistant.components.elkm1] is an invalid option for [logger]. Check: logger->logger->homeassistant.components.elkm1. (See /config/configuration.yaml, line 7). From: J. Nick Koston ***@***.***> Sent: Thursday, November 3, 2022 8:10 PM To: home-assistant/core ***@***.***> Cc: yestrdave ***@***.***>; Author ***@***.***> Subject: Re: [home-assistant/core] Can not add two secure instances of Elk M1 (Issue #81516) Just a tiny typo logger: homeassistant.components.elkm1: debug https://www.home-assistant.io/integrations/logger/ — Reply to this email directly, view it on GitHub<#81516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWMXKFPXE2QLJARMLDULNGLWGRH4RANCNFSM6AAAAAARWUJKVQ>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

yestrdave · 2022-11-04T00:16:09Z

logger:
default: info
logs:
homeassistant.components.elkm1: debug

this work?

gwww · 2022-11-04T00:23:19Z

Sorry for my "typo"; I cut/paste from a non-reliable source. Doh.

When editing configuration.yaml, indentation is important. So paste in exactly, with the logger: line at the very start of the line.

If you hover over the text below a little "Copy to clipboard" icon will pop up in the upper right.

logger:
  default: info
  logs:
    homeassistant.components.elkm1: debug

yestrdave · 2022-11-04T00:30:53Z

doesn't seam to give me much when I try to configure

2022-11-03 20:15:47.579 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.582 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.582 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.583 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.583 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.583 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.583 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.583 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.583 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.585 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7f05223e3f10>
2022-11-03 20:15:47.610 INFO (MainThread) [homeassistant.bootstrap] Home Assistant initialized in 25.34s
2022-11-03 20:15:47.611 INFO (MainThread) [homeassistant.core] Starting Home Assistant
2022-11-03 20:15:47.624 INFO (MainThread) [custom_components.hacs] Stage changed: HacsStage.STARTUP
2022-11-03 20:15:47.745 INFO (MainThread) [custom_components.hacs] Loading removed repositories
2022-11-03 20:15:48.652 INFO (MainThread) [custom_components.hacs] Loading known repositories
2022-11-03 20:15:49.284 INFO (MainThread) [custom_components.hacs] Starting recurring background task for downloaded repositories
2022-11-03 20:15:49.285 INFO (MainThread) [custom_components.hacs] Stage changed: HacsStage.RUNNING
2022-11-03 20:16:01.420 INFO (SyncWorker_9) [homeassistant.loader] Loaded ffmpeg from homeassistant.components.ffmpeg
2022-11-03 20:16:01.562 INFO (MainThread) [homeassistant.setup] Setting up ffmpeg
2022-11-03 20:16:01.614 INFO (MainThread) [homeassistant.setup] Setup of domain ffmpeg took 0.1 seconds
2022-11-03 20:16:01.683 INFO (SyncWorker_6) [homeassistant.loader] Loaded demo from homeassistant.components.demo
2022-11-03 20:17:07.118 DEBUG (MainThread) [homeassistant.components.elkm1.config_flow] Elk discovered from integration discovery: ElkSystem(mac_address='00:40:9D:DB:2A:FF', ip_address='192.168.91.12', port=2601)
2022-11-03 20:17:07.119 DEBUG (MainThread) [homeassistant.components.elkm1.discovery] Unique id is already present from discovery: ElkSystem(mac_address='00:40:9D:DB:2A:FF', ip_address='192.168.91.12', port=2601)
2022-11-03 20:17:07.119 DEBUG (MainThread) [homeassistant.components.elkm1.config_flow] Elk discovered from integration discovery: ElkSystem(mac_address='00:40:9D:C9:4F:18', ip_address='192.168.91.11', port=2601)
2022-11-03 20:28:43.847 INFO (MainThread) [homeassistant.helpers.storage] Migrating core.config storage from 1.1 to 1.2

yestrdave · 2022-11-04T00:31:49Z

192.168.91.11 is the one I want to configure

gwww · 2022-11-04T00:34:53Z

Start with neither ElkM1 configured and then add them. Send that log.

yestrdave · 2022-11-04T00:36:25Z

I've done that a couple times. doesnt seam to show in logs

yestrdave · 2022-11-04T00:37:05Z

gwww · 2022-11-04T00:44:09Z

Does it matter which order you add them in? Is it always the same IP address that fails?

yestrdave · 2022-11-04T00:45:06Z

here is an add non secure and it works

2022-11-03 20:43:51.038 INFO (MainThread) [elkm1_lib.connection] Connecting to ElkM1 at elk://192.168.91.11
2022-11-03 20:43:51.041 INFO (MainThread) [elkm1_lib.connection] Connected to ElkM1
2022-11-03 20:43:51.087 DEBUG (MainThread) [homeassistant.components.elkm1] ElkM1 login succeeded
2022-11-03 20:43:51.088 DEBUG (MainThread) [homeassistant.components.elkm1] Received login event
2022-11-03 20:43:51.088 DEBUG (MainThread) [homeassistant.components.elkm1] Waiting for sync_complete event for 120 seconds
2022-11-03 20:43:53.228 DEBUG (MainThread) [homeassistant.components.elkm1] Received sync_complete event
2022-11-03 20:43:53.229 INFO (MainThread) [homeassistant.components.alarm_control_panel] Setting up alarm_control_panel.elkm1
2022-11-03 20:43:53.229 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up binary_sensor.elkm1
2022-11-03 20:43:53.230 INFO (MainThread) [homeassistant.components.climate] Setting up climate.elkm1
2022-11-03 20:43:53.230 INFO (MainThread) [homeassistant.components.light] Setting up light.elkm1
2022-11-03 20:43:53.230 INFO (MainThread) [homeassistant.components.scene] Setting up scene.elkm1
2022-11-03 20:43:53.230 INFO (MainThread) [homeassistant.components.sensor] Setting up sensor.elkm1
2022-11-03 20:43:53.231 INFO (MainThread) [homeassistant.components.switch] Setting up switch.elkm1
2022-11-03 20:43:53.231 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.233 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.234 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>
2022-11-03 20:43:53.234 DEBUG (MainThread) [homeassistant.components.elkm1] Creating elk entities for <elkm1_lib.elk.Elk object at 0x7fa526542620>

yestrdave · 2022-11-04T00:45:23Z

No it does not matter what order

yestrdave · 2022-11-04T00:51:27Z

Ive tried everything it doesnt want to spit out a log

gwww · 2022-11-04T00:53:16Z

No worries. I'll ask again if I can't make progress.

gwww · 2022-11-04T02:27:14Z

@bdraco I can't figure out why this is happening (at least without add more debug logs). The only place I see the reported error message is here: https://github.com/home-assistant/core/blob/dev/homeassistant/components/elkm1/config_flow.py#L244

As I understand it, one Elk is discovered and added. The second discovered Elk throws this error. The images supplied show that. Do you have ideas?

bdraco · 2022-11-04T07:01:07Z

I wrote test to make sure we can add multiple instances and couldn't find a problem.

@yestrdave Is it possible there is a disabled or ignored instance already set up that is blocking the creation of the new one?

yestrdave · 2022-11-04T09:34:52Z

Pretty sure that’s not possible. I’ve duplicated on two different servers and the order doesn’t matter. I’ll go into the test server and go through the testing again to make sure.. Since the order does matter it eliminates the set up in the ElKRP too. I will go through and document this shortly. As a last resort I could fire up a fresh vmm and try also.

yestrdave · 2022-11-04T10:13:37Z

VMM Test
Home Assistant 2022.11.1
Supervisor 2022.10.2
Operating System 9.3
Frontend 20221102.1 – latest

Searched Alarm and Elk – Nothing appears to be hidden

Im going to do the one we have problems with in the Production setup first. 11 Main House

When I search elk everything shows up in entities as it should.
Then try to add Big Garage or 12

Reverse it. Deleted integration and restarted HA Big Garage first Main house second

Main House or 11 now shows as already configured

yestrdave · 2022-11-04T10:17:56Z

Just ran the test in a docker container and same result

gwww · 2022-11-04T14:24:54Z

Since you can run this on clean docker installs, could you do this:

Start the a clean docker version of HA
Get a copy of config/.storage/core.config_entries; add a -1 to the filename
At this point I'm expecting you see the 2 discovered Elks
Configure the .11 Elk
Get a copy of config/.storage/core.config_entries; add a -2 to the filename (so we can distinguish it)
Try to configure the .12 Elk
Get a copy of config/.storage/core.config_entries; add a -3 to the filename

Send us the 3 files. Make sure to remove your password from the files.

@bdraco I think this is useful. I don't know the internals really at all, does this request make sense?

gwww · 2022-11-04T23:51:16Z

Ignore last message, at least for now.

I have added some more debug messages to the code. You will have to install the Elk integration as a custom component. Copy the elkm1 directory and contents from here: https://www.dropbox.com/sh/96lxxckro2xdhkr/AABhCmSG6gRYSMeY_xluxE3Da?dl=0 to your config/custom_components directory (making the custom_components directory if it doesn't exist). You should end up with a directory structure config/custom_components/elkm1 and the elkm1 directory will have a bunch of Python files and other bits. The only change from the 2022.11.x version is added debug messages.

If you need help setting up custom_components don't hesitate to ask (I kept the instruction light here because many people already know how to do it).

Also replace your debug logging directives to the following:

logger:
  logs:
    custom_components.elkm1: debug

After those two things are done:

restart HA
Add the .11 Elk followed by the .12 Elk
Send the new logs. **passwords for your Elk will be in the logs and should be removed.

yestrdave · 2022-11-05T14:13:00Z

logs.txt

Used notepad plus to redact . Can save any format ya like. Here is a text file. Ill read up on Fenced code blocks

gwww · 2022-11-05T14:15:25Z

A text file is perfect. Use code blocks when pasting text in to a comment. I’ll take a look at the log in a bit. On my phone at the moment.

gwww · 2022-11-05T14:45:45Z

I'm narrowing in! I see a problem but don't understand why yet. Could you copy the code again from dropbox and rerun the test. I added one more log message.

yestrdave · 2022-11-05T15:06:37Z

on it

gwww · 2022-11-05T15:17:40Z

I found the problem! No need for you to continue at this point. Once I have a fix I will get you to test it as a custom_component.

@bdraco urlparse does not work for parsing strings such as elksv1_2://192.1.1.1. I don't know if there is a better library, better use of urlparse, or just use split. I will create a fix and submit PR later today.

yestrdave · 2022-11-05T15:18:56Z

ok its done if you want it
log2.txt

yestrdave · 2022-11-05T15:24:06Z

What an unbelievable Community we have here. I absolutely love the devotion and pride I have experienced here since switching to HA. The commitment everyone has here is outstanding. Thank you so much @GWW and @bdraco you guys rock.

gwww · 2022-11-05T15:27:36Z

My devotion is getting overruled by spouse at the moment ;) I'll be back later today with a fix. I know what to fix, just trying to find the best way.

gwww · 2022-11-05T15:28:27Z

The log confirms what I thought. Thanks.

yestrdave · 2022-11-05T16:55:27Z

My spouse is traveling for a couple days. I get to "geek out" uninterrupted today....lol

bdraco · 2022-11-05T17:41:26Z

@bdraco urlparse does not work for parsing strings such as elksv1_2://192.1.1.1. I don't know if there is a better library, better use of urlparse, or just use split. I will create a fix and submit PR later today.

@gwww Maybe try yarl

bdraco · 2022-11-05T17:42:48Z

yarl doesn't seem to work either

>>> from yarl import URL
>>> url = URL('elksv1_2://192.1.1.1')
>>> url
URL('elksv1_2://192.1.1.1')
>>> url.scheme
''
>>> url.host
>>> url.path
'elksv1_2://192.1.1.1'

bdraco · 2022-11-05T17:43:14Z

Every library I can find chokes on the _ in the scheme

bdraco · 2022-11-05T17:45:47Z

The best I could do was to make a new function that partitioned the url at ://, changed the protocol to a parsable string, reassembled it and put it through urlparse

gwww · 2022-11-05T18:33:12Z

All I do in the Elk library is just use split. The urls are simple in all cases.

Interested to know if the new test you wrote would work with the 1.2 scheme.

(I’m out on a hike. I can fix this tonight if you haven’t got to it)

bdraco · 2022-11-05T19:14:21Z

I’ll push something up soon. I’m super jet lagged as I just did a 3 day turn to Europe and back so make sure to double check whatever I write 😬

gwww · 2022-11-05T19:36:38Z

There’s this: https://github.com/gwww/elkm1/blob/main/elkm1_lib/util.py#L27

would work

bdraco · 2022-11-05T19:50:21Z

Nice. Will use that instead

fixes home-assistant#81516

bdraco · 2022-11-05T20:08:32Z

fixed in #81627

I use the function from the lib to parse the url

fixes #81516

gwww · 2022-11-09T02:29:55Z

@yestrdave the new patch release 2022.11.2 is out with this fix.

yestrdave · 2022-11-09T13:58:33Z

Thanks Glenn. Traveling until next week. I’ll try it out then. Thanks DaveR

…

________________________________ From: Glenn Waters ***@***.***> Sent: Tuesday, November 8, 2022 9:30:07 PM To: home-assistant/core ***@***.***> Cc: yestrdave ***@***.***>; Mention ***@***.***> Subject: Re: [home-assistant/core] Can not add two secure instances of Elk M1 when using TLS 1.2 (Issue #81516) @yestrdave<https://github.com/yestrdave> the new patch release 2022.11.2 is out with this fix. — Reply to this email directly, view it on GitHub<#81516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWMXKFLUG65V76W3WYMBZITWHMEC7ANCNFSM6AAAAAARWUJKVQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

yestrdave · 2022-11-11T18:55:09Z

Glenn and Nick we can close this one. I was able to VPN in from hotel and install second instance with no issues. Thank you both

bdraco · 2022-11-11T19:09:56Z

Thanks for confirming 👍

home-assistant bot added the integration: elkm1 label Nov 3, 2022

home-assistant bot assigned bdraco Nov 3, 2022

bdraco mentioned this issue Nov 4, 2022

Add additional coverage for adding multiple elkm1 instances #81528

Merged

19 tasks

bdraco changed the title ~~Can not add two secure instances of Elk M1~~ Can not add two secure instances of Elk M1 when using TLS 1.2 Nov 5, 2022

bdraco added a commit to bdraco/home-assistant that referenced this issue Nov 5, 2022

Fix creating multiple ElkM1 systems with TLS 1.2

5db05b8

fixes home-assistant#81516

bdraco mentioned this issue Nov 5, 2022

Fix creating multiple ElkM1 systems with TLS 1.2 #81627

Merged

19 tasks

MartinHjelmare closed this as completed in #81627 Nov 7, 2022

MartinHjelmare pushed a commit that referenced this issue Nov 7, 2022

Fix creating multiple ElkM1 systems with TLS 1.2 (#81627)

2bea775

fixes #81516

frenck pushed a commit that referenced this issue Nov 8, 2022

Fix creating multiple ElkM1 systems with TLS 1.2 (#81627)

e4269ff

fixes #81516

github-actions bot locked and limited conversation to collaborators Dec 11, 2022

Can not add two secure instances of Elk M1 when using TLS 1.2 #81516

Can not add two secure instances of Elk M1 when using TLS 1.2 #81516

Comments

yestrdave commented Nov 3, 2022

The problem

What version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Diagnostics information

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

home-assistant bot commented Nov 3, 2022

yestrdave commented Nov 3, 2022

gwww commented Nov 3, 2022

yestrdave commented Nov 3, 2022

gwww commented Nov 3, 2022

yestrdave commented Nov 4, 2022

bdraco commented Nov 4, 2022

yestrdave commented Nov 4, 2022 via email

yestrdave commented Nov 4, 2022

gwww commented Nov 4, 2022

yestrdave commented Nov 4, 2022

yestrdave commented Nov 4, 2022

gwww commented Nov 4, 2022

yestrdave commented Nov 4, 2022

yestrdave commented Nov 4, 2022

gwww commented Nov 4, 2022

yestrdave commented Nov 4, 2022

yestrdave commented Nov 4, 2022

yestrdave commented Nov 4, 2022

gwww commented Nov 4, 2022

gwww commented Nov 4, 2022

bdraco commented Nov 4, 2022

yestrdave commented Nov 4, 2022

yestrdave commented Nov 4, 2022

yestrdave commented Nov 4, 2022

gwww commented Nov 4, 2022

gwww commented Nov 4, 2022

yestrdave commented Nov 5, 2022

gwww commented Nov 5, 2022

gwww commented Nov 5, 2022

yestrdave commented Nov 5, 2022

gwww commented Nov 5, 2022

yestrdave commented Nov 5, 2022

yestrdave commented Nov 5, 2022

gwww commented Nov 5, 2022

gwww commented Nov 5, 2022

yestrdave commented Nov 5, 2022

bdraco commented Nov 5, 2022 • edited Loading

bdraco commented Nov 5, 2022

bdraco commented Nov 5, 2022

bdraco commented Nov 5, 2022

gwww commented Nov 5, 2022

bdraco commented Nov 5, 2022

gwww commented Nov 5, 2022

bdraco commented Nov 5, 2022

bdraco commented Nov 5, 2022

gwww commented Nov 9, 2022

yestrdave commented Nov 9, 2022 via email

yestrdave commented Nov 11, 2022

bdraco commented Nov 11, 2022

bdraco commented Nov 5, 2022 •

edited

Loading