Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit_of_measurement should not be capitalized #938

Closed
molobrakos opened this issue Jan 20, 2016 · 1 comment
Closed

unit_of_measurement should not be capitalized #938

molobrakos opened this issue Jan 20, 2016 · 1 comment

Comments

@molobrakos
Copy link
Contributor

unit_of_measurement gets capitalized so that "kW" becomes "KW", "mm" becomes "Mm", etc.

SI-prefixes such as "kilo" ("k") or "milli" ("m") should not be capitalized.
(However, "giga" ("G"), "tera" ("T"), etc should).

I would suggest not modifying the unit_of_measurement at all, i.e. use what is specified by the platform or in configuration.yaml

Not sure if this is a frontend or backend issue, i.e. where the conversion takes place.

@balloob
Copy link
Member

balloob commented Jan 20, 2016

It's a frontend thing. We capitalize the state + unit field using CSS.

On Tue, Jan 19, 2016, 23:59 Erik notifications@github.com wrote:

unit_of_measurement gets capitalized so that "kW" becomes "KW", "mm"
becomes "Mm", etc.

SI-prefixes such as "kilo" ("k") or "milli" ("m") should not be
capitalized.
(However, "giga" ("G"), "tera" ("T"), etc should).

I would suggest not modifying the unit_of_measurement at all, i.e. use
what is specified by the platform or in configuration.yaml

Not sure if this is a frontend or backend issue, i.e. where the conversion
takes place.


Reply to this email directly or view it on GitHub
#938.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants