Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options-flow in hvv_departures #102484

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Fix options-flow in hvv_departures #102484

merged 1 commit into from
Oct 22, 2023

Conversation

niklasheld
Copy link
Contributor

Breaking change

Proposed change

The options config-flow for the hvv_departures integration currently fails to load for some stations.

This is caused by an outdated schema in the pygti-library, which causes the validation of the station used in the departureList query to fail. While this issue should also be fixed in the library, this PR changes the query to use only the minimally required data and might prevent issues like this from occuring in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niklasheld

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 21, 2023 18:37
@home-assistant
Copy link

Hey there @vigonotion, mind taking a look at this pull request as it has been labeled with an integration (hvv_departures) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hvv_departures can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign hvv_departures Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@niklasheld niklasheld marked this pull request as ready for review October 21, 2023 19:20
Copy link
Contributor

@vigonotion vigonotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 22, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @niklasheld 👍

../Frenck

@frenck frenck merged commit af264c6 into home-assistant:dev Oct 22, 2023
23 checks passed
iotmaestro pushed a commit to iotmaestro/home-assistant-core that referenced this pull request Oct 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed Hacktoberfest integration: hvv_departures Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HVV departures integration fails to load config-flow
3 participants