-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase gardena_bluetooth timeout and disconnect delay #106282
Increase gardena_bluetooth timeout and disconnect delay #106282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alistair23
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @elupus, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Increase the disconnect delay and the timeout for the Gardena water computer. As discussed at: home-assistant#103117 this greatly improves the reliability of the device. Signed-off-by: Alistair Francis <alistair@alistair23.me>
7860000
to
638d8fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can not be the default. This blocks access to the device from mobile clients. It needs to be an option, something like persistent connection.
Do you know how to add an option like that? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
Increase the disconnect delay and the timeout for the Gardena water computer. As discussed at:
#103117 this greatly improves the reliability of the device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: