More declarative timeout syntax for manual alarm control panel #10738

bonzini · 2017-11-22T00:15:27Z

Description:

This series adds new settings to the manual alarm control panel, so that the state machine is able to express many common use cases in an entirely declarative manner, without relying on "for" and "condition" checks. For more information, see the doc pull request. The changes are all included in the MQTT version as well.

In addition, it adds the possibility to compute the code with a jinja template, thus enabling integration with the OTP sensor.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#4039

Example entry for `configuration.yaml` (if applicable):

alarm_control_panel:
  - platform: manual
    code: 1234
    pending_time: 30
    delay_time: 20
    trigger_time: 4
    disarmed:
      trigger_time: 0
    armed_home:
      pending_time: 0
      delay_time: 0

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code does not interact with devices:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
Tests have been added to verify that the new code works.

homeassistant · 2017-11-22T00:15:28Z

Hi @bonzini,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

bonzini · 2017-11-22T16:15:28Z

Sorry for pushing a set of commits that failed travis (I didn't notice I had to update the demo component), it is fixed now and I also tested the demo component locally since it lacks unit tests.

For a better idea of where I am going with these changes, see here which would be my next pull request.

The "group" component used in the linked cookbook recipe allows for an even easier and more declarative alarm configuration. Code-wise, it relies on the pre_pending_state attribute introduced by this pull request in order to compute the state of the group panel.

MartinHjelmare · 2017-11-22T17:13:45Z

After reading your documentation PR, I think this makes sense and is a good addition. I've skimmed the code, but it's a quite many lines so I'll go through it more later if nobody else claims this.

bonzini · 2017-11-22T18:07:01Z

Thanks! Of course most of it is tests, the logic changes are relatively small and the backwards-compatibility should be almost self-evident.

For the future, do you prefer to change tests in separate commits or in the same?

MartinHjelmare

I've only looked at the manual platform so far and no tests. You need to rebase on dev too, and solve the conflicts.

MartinHjelmare · 2017-11-26T14:01:22Z

homeassistant/components/alarm_control_panel/manual.py

    vol.Optional(CONF_PENDING_TIME, default=DEFAULT_PENDING_TIME):
        vol.All(vol.Coerce(int), vol.Range(min=0)),
    vol.Optional(CONF_TRIGGER_TIME, default=DEFAULT_TRIGGER_TIME):
-        vol.All(vol.Coerce(int), vol.Range(min=1)),


Do you know why CONF_TRIGGER_TIME was set to min 1 before?

Maybe add this as a comment here:
# A trigger_time of zero disables the alarm_trigger service.

I don't, but CONF_PENDING_TIME also started as min=1 and then was changed to min=0. It seems to me that leaving min=1 for CONF_TRIGGER_TIME was an oversight when adding those if self._trigger_time: checks.

MartinHjelmare · 2017-11-26T14:13:33Z

homeassistant/components/alarm_control_panel/manual.py

+            self._code = code_template
+            self._code.hass = hass
+        else:
+            self._code = str(code) if code else None


The code is already validated as a string if set in the config. If we want to check for empty string, I think we should do that already in the config validation. Could you add a validator that raises vol.Invalid for empty string? You should be able to use vol.IsTrue().

I think the purpose here is to make code = '' equivalent to no code at all. I'll change it to self._code = code or None.

MartinHjelmare · 2017-11-26T14:17:44Z

homeassistant/components/alarm_control_panel/manual.py

+        self._delay_time_by_state = {}
+        self._trigger_time_by_state = {}
+        for state in SUPPORTED_PRETRIGGER_STATES:
+            self._delay_time_by_state[state] = datetime.timedelta(


Use the time_period_seconds validator from config_validation.py during config validation.

This was just copied from pending time handling, so I'll clean that one up as well.

MartinHjelmare · 2017-11-26T14:17:52Z

homeassistant/components/alarm_control_panel/manual.py

+        for state in SUPPORTED_PRETRIGGER_STATES:
+            self._delay_time_by_state[state] = datetime.timedelta(
+                seconds=config[state][CONF_DELAY_TIME])
+            self._trigger_time_by_state[state] = datetime.timedelta(


Same as above.

MartinHjelmare · 2017-11-26T14:21:45Z

homeassistant/components/alarm_control_panel/manual.py

+            self._delay_time_by_state[state] = datetime.timedelta(
+                seconds=config[state][CONF_DELAY_TIME])
+            self._trigger_time_by_state[state] = datetime.timedelta(
+                seconds=config[state][CONF_TRIGGER_TIME])
        self._pending_time_by_state = {}
        for state in SUPPORTED_PENDING_STATES:
            self._pending_time_by_state[state] = datetime.timedelta(


Same as above.

MartinHjelmare

Add two comments as clarification and update docstrings for tests.

We should also consider labeling this PR as breaking, since the test test_trigger_with_specific_pending has changed.

MartinHjelmare · 2017-12-02T11:24:19Z

homeassistant/components/alarm_control_panel/manual.py

@@ -186,33 +240,45 @@ def alarm_arm_custom_bypass(self, code=None):

    def alarm_trigger(self, code=None):
        """Send alarm trigger command. No code needed."""
-        self._pre_trigger_state = self._state
+        if not self._trigger_time_by_state[self._active_state]:
+            return


Add a comment here why, ie "A trigger_time of zero disables the alarm_trigger service."

MartinHjelmare · 2017-12-02T11:26:25Z

homeassistant/components/alarm_control_panel/manual_mqtt.py

@@ -216,33 +270,45 @@ def alarm_arm_night(self, code=None):

    def alarm_trigger(self, code=None):
        """Send alarm trigger command. No code needed."""
-        self._pre_trigger_state = self._state
+        if not self._trigger_time_by_state[self._active_state]:
+            return


Same as above.

MartinHjelmare · 2017-12-02T11:45:10Z

tests/components/alarm_control_panel/test_manual_mqtt.py

+        assert state.state == STATE_ALARM_TRIGGERED
+
+    def test_trigger_with_pending_and_specific_delay(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:45:37Z

tests/components/alarm_control_panel/test_manual_mqtt.py

                         self.hass.states.get(entity_id).state)

-        future = dt_util.utcnow() + timedelta(seconds=2)
+    def test_arm_away_after_disabled_disarmed(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:46:00Z

tests/components/alarm_control_panel/test_manual_mqtt.py

+        assert state.state == STATE_ALARM_TRIGGERED
+
+    def test_trigger_with_pending_and_delay(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:55:09Z

tests/components/alarm_control_panel/test_manual.py

@@ -355,6 +475,203 @@ def test_trigger_with_pending(self):
        state = self.hass.states.get(entity_id)
        assert state.state == STATE_ALARM_DISARMED

+    def test_trigger_with_unused_specific_delay(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:55:19Z

tests/components/alarm_control_panel/test_manual.py

+                         self.hass.states.get(entity_id).state)
+
+    def test_trigger_zero_trigger_time_with_pending(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:55:27Z

tests/components/alarm_control_panel/test_manual.py

+        self.assertEqual(STATE_ALARM_TRIGGERED, state.state)
+
+    def test_trigger_zero_trigger_time(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:55:36Z

tests/components/alarm_control_panel/test_manual.py

@@ -311,6 +344,93 @@ def test_trigger_no_pending(self):
        self.assertEqual(STATE_ALARM_TRIGGERED,
                         self.hass.states.get(entity_id).state)

+    def test_trigger_with_delay(self):
+        """Test arm home method."""


Stale docstring.

MartinHjelmare · 2017-12-02T11:56:05Z

tests/components/alarm_control_panel/test_manual.py

@@ -140,6 +140,32 @@ def test_arm_away_no_pending(self):
        self.assertEqual(STATE_ALARM_ARMED_AWAY,
                         self.hass.states.get(entity_id).state)

+    def test_arm_home_with_template_code(self):
+        """Attempt to arm home without a valid code."""


Stale docstring.

bonzini · 2017-12-02T14:50:07Z

I'll do the updates, thanks! I don't think the pull request should be breaking, because the changes to the tests are just widening the block where a mock is used (to avoid that time goes "backwards"). There is no behavior change when measuring real time.

Make sure that both tests try the same scenarios, so that the same changes can be applied to both.

Currently it's not clear what prevents a switch from a state "to itself" while the transition is pending. Extend the _pre_trigger_state infrastructure to avoid that case, and expose it as a new attribute for users and tests. It will also come in handy when implementing per-state delay and trigger times. Tests are added in a later patch (currently, tests do not cover post_pending_state either). Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Change it to cv.time_period, remove it from ManualAlarm constructor since it is always filled in for each individual alarm state.

houndci-bot · 2017-12-02T16:40:02Z

homeassistant/components/alarm_control_panel/manual_mqtt.py

-
+        """
+        Send alarm trigger command.
+        


blank line contains whitespace

houndci-bot · 2017-12-02T16:40:02Z

homeassistant/components/alarm_control_panel/manual.py

-
+        """
+        Send alarm trigger command.
+        


blank line contains whitespace

Change it to cv.time_period; in order to use cv.positive_timedelta, fix up the code to allow specifying a zero trigger time. A zero trigger time disables triggering the alarm. The code is more or less already there, but was not active because the schema requests a minimum of one second for the trigger_time. This is not very useful as is, but it will be after the next patch to make the trigger time customizable per-state.

During a pending state, the trigger_time is the one of the previous state. This lets the user implement a "true" disarmed state, without having to test it in the conditions for the alarm control panel's state. This simplifies the automation if you are not interested in multiple states. For example you can just add disarmed: trigger_time: 0 in the manual alarm and omit the condition: - condition: state entity_id: alarm_control_panel.ha_alarm state: armed_away in all the actions. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

The delay_time argument is complementary to pending_time. Instead of causing the alarm to become PENDING when switching to a state, it causes the alarm to become PENDING when switching *from* a state to the TRIGGERED state. For example, you could set a delay_time to 30 if opening the garage door will take 30 seconds, during which the dog could walk in front of the door and trigger a presence alarm. The delay time can also be set per state; for example, at night doors are supposed to be closed, and a presence alarm would necessarily be triggered "by the inside"; so "armed_night" would have zero delay_time. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

This lets you specify a code only when disarming, use OTP sensors to generate codes, and much more. The only limit is your imagination!

MartinHjelmare

Ok, looks good.

For the future please don't squash the commits during the review process. That makes it very hard to follow the changes. I've done some sampling of the code and it looks good, but I won't go over everything again.

@MartinHjelmare

* Updated codeowner for Tile device tracker (home-assistant#10861) * Revert "KNX: Added config option for broadcasting current time to KNX bus. (home-assistant#10654)" (home-assistant#10874) This reverts commit cadd797. As discussed within home-assistant#10708 we should chose a different implementation. Therefore we should revert this change to avoid a breaking change. * Upgrade distro to 1.1.0 (home-assistant#10850) * Bugfix trigger state with multible entities (home-assistant#10857) * Bugfix trigger state with multible entities * Fix numeric state * fix lint * fix dict * fix unsub * fix logic * fix name * fix new logic * add test for state * add numeric state test for unsub * add test for multible entities * Update numeric_state.py * Update numeric_state.py * Update state.py * Fix logic for triple match * Add clear to numeric state * clear for state trigger * tellstick fix DEPENDENCIES and update tellcore-net (home-assistant#10859) * Update requirements_all.txt * Update tellstick.py * Fix DEPENDENCIES * Update requirements_all.txt * fix format * fix lint * fix lint * Update tellstick.py * update tellcore-net * update tellcore-net * besser validate * Update frontend to 20171130.0 * Upgrade aiohttp to 2.3.5 (home-assistant#10889) * Upgrade fastdotcom to 0.0.3 (home-assistant#10886) * Upgrade schiene to 0.19 (home-assistant#10887) * Xiaomi Vacuum: remove deprecated calls (home-assistant#10839) * vacuum.xiaomi_miio: read dnd status properly instead of using imprecise dnd flag from vacuum_state * vacuum.xiaomi_miio: use miio package instead of mirobo * check only that wanted calls have taken place, ignore order of calls * Fix linting issues * Remove empty line after docstring * Create ecobee weather platform (home-assistant#10869) * Create ecobee weather component * Update requirements_all for ecobee * Fix missed lint issue * Microsoft Text-to-speech: Fixing missing en-gb support bug (home-assistant#10429) * Fixing missing en-gb support bug * Microsoft TTS adding support for rate, volume, pitch and contour. * Microsoft TTS fixing support for jp-jp. * Fixing linting error on line 67 * make impossible things possible 🎉 * Upgrade youtube_dl to 2017.11.26 (home-assistant#10890) * Upgrade yarl to 0.15.0 (home-assistant#10888) * Fix tests (home-assistant#10891) * Refactored WHOIS sensor to resolve assumed key errors (home-assistant#10662) * Refactored WHOIS sensor to resolve assumed key errors Altered it to now set an attribute key and value only if the attribute is present in the WHOIS response. This prevents assumed keys (registrar) from raising a KeyError on WHOIS lookups that don't contain registrar information (onet.pl, wp.pl, for example). * Removed non-used self._data * WHOIS sensor now creates a new local attributes dict and overrides * Corrected typos, refactored error cases to clear state adn attributes * Resolved double return and refactored error logging * Serve latest extra_html in dev mode (home-assistant#10863) * Reload groups after saving a change via config API (home-assistant#10877) * Version bump to 0.59.0 * Update ecobee version to fix stack-trace issue (home-assistant#10894) * Pybotvac multi (home-assistant#10843) * Update requirements_all.txt * Update neato.py * Fix issues from review of ecobee weather component (home-assistant#10903) * Fix issues from review * Don't use STATE_UNKNOWN * Bugfix home-assistant#10902 (home-assistant#10904) * Fix issues from review of ecobee weather component (home-assistant#10903) * Fix issues from review * Don't use STATE_UNKNOWN * Bugfix home-assistant#10902 (home-assistant#10904) * More declarative timeout syntax for manual alarm control panel. (home-assistant#10738) More declarative timeout syntax for manual alarm control panel * Unpacking RESTful sensor JSON results into attributes. (home-assistant#10753) * Added support for extracting JSON attributes from RESTful values Setting the json_attributes configuration option to true on the RESTful sensor will cause the result of the REST request to be parsed as a JSON string and if successful the resulting dictionary will be used for the attributes of the sensor. * Added support for extracting JSON attributes from RESTful values Setting the json_attributes configuration option to true on the RESTful sensor will cause the result of the REST request to be parsed as a JSON string and if successful the resulting dictionary will be used for the attributes of the sensor. * Added requirement that RESTful JSON results used as attributes must be objects, not lists. * Expanded test coverage to test REFTful JSON attributes with and without a value template. * Added support for extracting JSON attributes from RESTful values Setting the json_attributes configuration option to true on the RESTful sensor will cause the result of the REST request to be parsed as a JSON string and if successful the resulting dictionary will be used for the attributes of the sensor. * Added requirement that RESTful JSON results used as attributes must be objects, not lists. * Expanded test coverage to test REFTful JSON attributes with and without a value template. * sensor.envirophat: add missing requirement (home-assistant#7451) Adding requirements that is not explicitly pulled in by the library that manages the Enviro pHAT. * PyPI Openzwave (home-assistant#7415) * Remove default zwave config path PYOZW now has much more comprehensive default handling for the config path (in src-lib/libopenzwave/libopenzwave.pyx:getConfig()). It looks in the same place we were looking, plus _many_ more. It will certainly do a much better job of finding the config files than we will (and will be updated as the library is changed, so we don't end up chasing it). The getConfig() method has been there for a while, but was subsntially improved recently. This change simply leaves the config_path as None if it is not specified, which will trigger the default handling in PYOZW. * Install python-openzwave from PyPI As of version 0.4, python-openzwave supports installation from PyPI, which means we can use our 'normal' dependency management tooling to install it. Yay. This uses the default 'embed' build (which goes and downloads statically sources to avoid having to compile anything locally). Check out the python-openzwave readme for more details. * Add python-openzwave deps to .travis.yml Python OpenZwave require the libudev headers to build. This adds the libudev-dev package to Travis runs via the 'apt' addon for Travis. Thanks to @MartinHjelmare for this fix. * Update docker build for PyPI openzwave Now that PYOZW can be install from PyPI, the docker image build process can be simplified to remove the explicit compilation of PYOZW. * Add datadog component (home-assistant#7158) * Add datadog component * Improve test_invalid_config datadog test * Use assert_setup_component for test setup * Fix object type for default KNX port home-assistant#7429 describes a TypeError that is raised if the port is omitted in the config for the KNX component (integer is required (got type str)). This commit changes the default port from a string to an integer. I expect this will resolve that issue... * Added support for extracting JSON attributes from RESTful values Setting the json_attributes configuration option to true on the RESTful sensor will cause the result of the REST request to be parsed as a JSON string and if successful the resulting dictionary will be used for the attributes of the sensor. * Added requirement that RESTful JSON results used as attributes must be objects, not lists. * Expanded test coverage to test REFTful JSON attributes with and without a value template. * Added support for extracting JSON attributes from RESTful values Setting the json_attributes configuration option to true on the RESTful sensor will cause the result of the REST request to be parsed as a JSON string and if successful the resulting dictionary will be used for the attributes of the sensor. * Added requirement that RESTful JSON results used as attributes must be objects, not lists. * Expanded test coverage to test REFTful JSON attributes with and without a value template. * Added support for extracting JSON attributes from RESTful values Setting the json_attributes configuration option to true on the RESTful sensor will cause the result of the REST request to be parsed as a JSON string and if successful the resulting dictionary will be used for the attributes of the sensor. * Added requirement that RESTful JSON results used as attributes must be objects, not lists. * Expanded test coverage to test REFTful JSON attributes with and without a value template. * Fixed breaks cause by manual upstream merge. * Added one extra blank line to make PyLint happy. * Switched json_attributes to be a list of keys rather than a boolean. The value of json_attributes can now be either a comma sepaated list of key names or a YAML list of key names. Only matching keys in a retuned JSON dictionary will be mapped to sensor attributes. Updated test cases to handle json_attributes being a list. Also fixed two minor issues arrising from manual merge with 0.58 master. * Added an explicit default value to the json_attributes config entry. * Removed self.update() from __init__() body. * Expended unit tests for error cases of json_attributes processing. * Align quotes * Bump dev to 0.60.0.dev0 (home-assistant#10912) * Update eliqonline.py (home-assistant#10914) Channel id is now required (change in API) * Add iAlarm support (home-assistant#10878) * Add iAlarm support * Minor fixes to iAlarm * Rename ialarmpanel to ialarm and add a check for the host value * corrections in the value validation of ialarm * add a missing period on ialarm * Correction of Samsung Power OFF behaviour (home-assistant#10907) * Correction of Samsung Power OFF behaviour Addition of a delay after powering OFF a Samsung TV, this avoid status update from powering the TV back ON. Deletion of update() return statement, return value not used. * Rename self._end_of_power_off_command into self._end_of_power_off * Removal of unused line break in Samsung TV component * Add Alpha Vantage sensor (home-assistant#10873) * Add Alpha Vantage sensor * Remove data object * Remove unused vars and change return * Fix typo * Don't repeat getting receiver name on each update / pushed to denonavr 0.5.5 (home-assistant#10915) * Add Min and Event Count Metrics To Prometheus (home-assistant#10530) * Added min and Events sensor types to prometheus * Updated prometheus client and fixed invalid swith state * Added metric to count number of times an automation is triggered * Removed assumption that may not apply to everybody * Fixed tests * Updated requirements_test_all * Fixed unit tests * fix ios component config generation (home-assistant#10923) Fixes: home-assistant#19020 * Fix Notifications for Android TV (home-assistant#10798) * Fixed icon path, added dynamic icon * Addressing requested changes * Using DEFAULT_ICON * Using CONF_ICON from const * Getting hass_frontend path via import * Lint * Using embedded 1px transparent icon * woof -.- * Lint * Update coveragerc (home-assistant#10931) * Sort coveragerc * Add climate.honeywell and vacuum.xiaomi_miio to coveragerc * Update frontend to 20171204.0 (home-assistant#10934) * Dominos no order fix (home-assistant#10935) * check for none * fix error from no store being set * typo * Lint * fix default as per notes. Lint fix and make closest store None not False * update default * Version bump to 0.59.1 * Fix Notifications for Android TV (home-assistant#10798) * Fixed icon path, added dynamic icon * Addressing requested changes * Using DEFAULT_ICON * Using CONF_ICON from const * Getting hass_frontend path via import * Lint * Using embedded 1px transparent icon * woof -.- * Lint * fix ios component config generation (home-assistant#10923) Fixes: home-assistant#19020 * Update frontend to 20171204.0 (home-assistant#10934) * Dominos no order fix (home-assistant#10935) * check for none * fix error from no store being set * typo * Lint * fix default as per notes. Lint fix and make closest store None not False * update default * Report availability of TP-Link smart sockets (home-assistant#10933) * Report availability of TP-Link smart sockets * Changes according to our style guide * Set percent unit for battery level so that history displays properly; edited variable name for consistency (home-assistant#10932) * Export climate status and target temperature to Prometheus (home-assistant#10919) * Export climate metrics to Prometheus. This adds climate_state and temperature_c metrics for each climate device. * Add more climate states to state_as_number * Tado ignore invalid devices (home-assistant#10927) * Ignore devices without temperatures * Typo * Linting * Removing return false * Another typo. :( * Spelling received correctly * Upgrade tellduslive library version (closes home-assistant#10922) (home-assistant#10950) * don't ignore voltage data if sensor data changed (home-assistant#10925) * Fix linksys_ap.py by inheriting DeviceScanner (home-assistant#10947) As per issue home-assistant#8638, the class wasn't inheriting from DeviceScanner, this commit patches it up. * Add ADS component (home-assistant#10142) * add ads hub, light and switch * add binary sensor prototype * switch: use adsvar for connection * fix some issues with binary sensor * fix binary sensor * fix all platforms * use latest pyads * fixed error with multiple binary sensors * add sensor * add ads sensor * clean up after shutdown * ads component with platforms switch, binary_sensor, light, sensor add locking poll sensors at startup update state of ads switch and light update ads requirements remove update() from constructors on ads platforms omit ads coverage ads catch read error when polling * add ads service * add default settings for use_notify and poll_interval * fix too long line * Fix style issues * no pydocstyle errors * Send and receive native brightness data to ADS device to prevent issues with math.floor reducing brightness -1 at every switch * Enable non dimmable lights * remove setting of self._state in switch * remove polling * Revert "remove polling" This reverts commit 7da420f. * add service schema, add links to documentation * fix naming, cleanup * re-remove polling * use async_added_to_hass for setup of callbacks * fix comment. * add callbacks for changed values * use async_add_job for creating device notifications * set should_poll to False for all platforms * change should_poll to property * add service description to services.yaml * add for brigthness not being None * put ads component in package * Remove whitespace * omit ads package * Reload closest store on api menu request (home-assistant#10962) * reload closest store on api request * revert change from debugging * Gearbest sensor (home-assistant#10556) * Added Gearbest Sensor * Updated required files * Fixed houndci-bout findings * Fix tox lint errors * Changed code according to review Implemented library version 1.0.5 * Fixed houndci-bot findings * Fixed tox lint issues * Updated item schema to use has_at_least_one_key Added conf constants * Remove CONF_ constants and import them from homeassistant.const * Removed CurrencyConverter from hass Fixed couple of issues found by MartinHjelmare * Add Ziggo Mediabox XL media_player (home-assistant#10514) * Add Ziggo Mediabox XL media_player * Using pypi module ziggo-mediabox-xl now. * Code review changes * Generic thermostat initial_operation_mode (home-assistant#10690) * Generic thermostat restore operation mode * Test restore operation mode * Fix trailing whitespace * Fix line too long * Fix test duplicate entity_id * Fix test * async_added_to_hass modify modify internal state * Test inital_operation_mode * More restore state tests * Fix whitespace * fix test_custom_setup_param * Test "None" target temp * Use new build path for dev translations (home-assistant#10937) * Add option to set default hide if away for new devices (home-assistant#10762) * Option to change hide_if_away * tests fix * change new device defaults * tests and requested changes * fix assert * Allow chime to work for wink siren/chime (home-assistant#10961) * Allow Wink siren/chimes to work * Updated requirements_all.txt * Revert pychromecast update (home-assistant#10989) * Revert pychromecast update * Update cast.py * Require FF43 for latest js (home-assistant#10941) * Require FF43 for latest js `Array.prototype.includes` added in Firefox 43 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes * Update __init__.py * Version bump to 0.59.2 * Require FF43 for latest js (home-assistant#10941) * Require FF43 for latest js `Array.prototype.includes` added in Firefox 43 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes * Update __init__.py * Fix linksys_ap.py by inheriting DeviceScanner (home-assistant#10947) As per issue home-assistant#8638, the class wasn't inheriting from DeviceScanner, this commit patches it up. * Upgrade tellduslive library version (closes home-assistant#10922) (home-assistant#10950) * Reload closest store on api menu request (home-assistant#10962) * reload closest store on api request * revert change from debugging * Allow chime to work for wink siren/chime (home-assistant#10961) * Allow Wink siren/chimes to work * Updated requirements_all.txt * Revert pychromecast update (home-assistant#10989) * Revert pychromecast update * Update cast.py * Allow disabling the LEDs on TP-Link smart plugs (home-assistant#10980) * Update frontend to 20171206.0 * Meraki AP Device tracker (home-assistant#10971) * Device tracker for meraki AP * styles fix * fix again * again * and again :) * fix hide if away * docs and optimization * tests and fixes * styles * styles * styles * styles * styles fix. Hope last * clear track new * changes * fix accuracy error and requested changes * remove meraki from .coveragerc * tests and minor changes * remove location * Update tradfri.py (home-assistant#10991) * webostv: Ensure source exists before use (home-assistant#10959) In a case where either (a) an incorrect source name is used, or (b) the TV isn't currently queryable (e.g. it's off), we get tracebacks because we assume the source that we are being asked to select exists in self._source_list. This makes the lookup code a little more rugged, and adds in a warning message (in place of the current exception). * Ensure Docker script files uses LF line endings to support Docker for Windows. (home-assistant#10067) * Added Vera scenes (home-assistant#10424) * Added Vera scenes * Fixed flake8 issues * Fixed comments * Moved vera to use hass.data * Made requested changes * Fix Egardia alarm status shown as unknown after restart (home-assistant#11010)

bonzini requested a review from a team as a code owner November 22, 2017 00:15

homeassistant added platform: alarm_control_panel.manual cla-needed labels Nov 22, 2017

balloobbot added core platform labels Nov 22, 2017

bonzini mentioned this pull request Nov 22, 2017

Update manual and manual_mqtt alarm platform for upcoming changes home-assistant/home-assistant.io#4039

Merged

2 tasks

homeassistant added cla-signed and removed cla-needed labels Nov 22, 2017

bonzini force-pushed the alarm-manual branch from 787bc4e to 6e5e219 Compare November 22, 2017 11:08

homeassistant added the cla-signed label Nov 22, 2017

bonzini force-pushed the alarm-manual branch from 6e5e219 to 1f0bfc1 Compare November 22, 2017 15:59

homeassistant added the cla-signed label Nov 22, 2017

MartinHjelmare reviewed Nov 26, 2017

View reviewed changes

bonzini force-pushed the alarm-manual branch from 1f0bfc1 to 6f16559 Compare November 29, 2017 00:16

homeassistant added the cla-signed label Nov 29, 2017

bonzini force-pushed the alarm-manual branch from 6f16559 to 93a2f53 Compare November 29, 2017 08:20

homeassistant added the cla-signed label Nov 29, 2017

bonzini force-pushed the alarm-manual branch from 93a2f53 to 862b87f Compare November 29, 2017 23:09

homeassistant added the cla-signed label Nov 29, 2017

MartinHjelmare requested changes Dec 2, 2017

View reviewed changes

bonzini added 4 commits December 2, 2017 16:01

alarm/manual_mqtt: sync different test with alarm/manual

c16c604

Make sure that both tests try the same scenarios, so that the same changes can be applied to both.

alarm/manual, alarm/manual_mqtt: fix doc comment

e391732

alarm/manual, alarm/manual_mqtt: cleanup pending_time

15192c2

Change it to cv.time_period, remove it from ManualAlarm constructor since it is always filled in for each individual alarm state.

bonzini force-pushed the alarm-manual branch from 862b87f to 2047d5c Compare December 2, 2017 16:30

homeassistant added the cla-signed label Dec 2, 2017

bonzini force-pushed the alarm-manual branch from 2047d5c to 7096d34 Compare December 2, 2017 16:39

homeassistant added the cla-signed label Dec 2, 2017

houndci-bot reviewed Dec 2, 2017

View reviewed changes

bonzini added 4 commits December 2, 2017 17:41

alarm/manual, alarm/manual_mqtt: add template-based code

c8e9ff8

This lets you specify a code only when disarming, use OTP sensors to generate codes, and much more. The only limit is your imagination!

bonzini force-pushed the alarm-manual branch from 7096d34 to c8e9ff8 Compare December 2, 2017 16:41

homeassistant added the cla-signed label Dec 2, 2017

MartinHjelmare approved these changes Dec 2, 2017

View reviewed changes

MartinHjelmare changed the title ~~More declarative timeout syntax for manual alarm control panel.~~ More declarative timeout syntax for manual alarm control panel Dec 3, 2017

MartinHjelmare merged commit 0f8e48c into home-assistant:dev Dec 3, 2017

fabaff mentioned this pull request Dec 16, 2017

0.60 #11153

Merged

home-assistant locked and limited conversation to collaborators Mar 30, 2018

ghost added integration: manual integration: manual_mqtt and removed platform: alarm_control_panel.manual labels Mar 21, 2019

bonzini deleted the alarm-manual branch November 21, 2022 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More declarative timeout syntax for manual alarm control panel #10738

More declarative timeout syntax for manual alarm control panel #10738

bonzini commented Nov 22, 2017 •

edited

Loading

homeassistant commented Nov 22, 2017

bonzini commented Nov 22, 2017 •

edited

Loading

MartinHjelmare commented Nov 22, 2017

bonzini commented Nov 22, 2017

MartinHjelmare left a comment

MartinHjelmare Nov 26, 2017 •

edited

Loading

MartinHjelmare Nov 26, 2017

bonzini Nov 27, 2017

MartinHjelmare Nov 26, 2017

bonzini Nov 27, 2017

MartinHjelmare Nov 26, 2017

bonzini Nov 27, 2017

MartinHjelmare Nov 26, 2017

MartinHjelmare Nov 26, 2017

MartinHjelmare left a comment

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

MartinHjelmare Dec 2, 2017

bonzini commented Dec 2, 2017

houndci-bot Dec 2, 2017

houndci-bot Dec 2, 2017

MartinHjelmare left a comment

More declarative timeout syntax for manual alarm control panel #10738

More declarative timeout syntax for manual alarm control panel #10738

Conversation

bonzini commented Nov 22, 2017 • edited Loading

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented Nov 22, 2017

bonzini commented Nov 22, 2017 • edited Loading

MartinHjelmare commented Nov 22, 2017

bonzini commented Nov 22, 2017

MartinHjelmare left a comment

Choose a reason for hiding this comment

MartinHjelmare Nov 26, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinHjelmare left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bonzini commented Dec 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinHjelmare left a comment

Choose a reason for hiding this comment

bonzini commented Nov 22, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

bonzini commented Nov 22, 2017 •

edited

Loading

MartinHjelmare Nov 26, 2017 •

edited

Loading