Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Notifications for Android TV #10798

Merged
merged 9 commits into from
Dec 3, 2017
Merged

Fix Notifications for Android TV #10798

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
98bec40
Fixed icon path, added dynamic icon
danielperna84 Nov 25, 2017
a92374b
Addressing requested changes
danielperna84 Nov 25, 2017
7ef6019
Using DEFAULT_ICON
danielperna84 Nov 25, 2017
f87560a
Using CONF_ICON from const
danielperna84 Nov 26, 2017
56a3de9
Getting hass_frontend path via import
danielperna84 Nov 27, 2017
5e5ba26
Lint
danielperna84 Nov 27, 2017
a459203
Using embedded 1px transparent icon
danielperna84 Dec 3, 2017
4df8316
woof -.-
danielperna84 Dec 3, 2017
eceb4c8
Lint
danielperna84 Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions homeassistant/components/notify/nfandroidtv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,16 @@
"""
import os
import logging
import io
import base64

import requests
import voluptuous as vol

from homeassistant.components.notify import (
ATTR_TITLE, ATTR_TITLE_DEFAULT, ATTR_DATA, BaseNotificationService,
PLATFORM_SCHEMA)
from homeassistant.const import CONF_TIMEOUT
from homeassistant.const import CONF_TIMEOUT, CONF_ICON
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'homeassistant.const.CONF_ICON' imported but unused

import homeassistant.helpers.config_validation as cv

_LOGGER = logging.getLogger(__name__)
Expand All @@ -31,6 +33,9 @@
DEFAULT_COLOR = 'grey'
DEFAULT_INTERRUPT = False
DEFAULT_TIMEOUT = 5
DEFAULT_ICON = (
'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR4nGP6zwAAAgcBApo'
'cMXEAAAAASUVORK5CYII=')

ATTR_DURATION = 'duration'
ATTR_POSITION = 'position'
Expand Down Expand Up @@ -110,16 +115,13 @@ def __init__(self, remoteip, duration, position, transparency, color,
self._default_color = color
self._default_interrupt = interrupt
self._timeout = timeout
self._icon_file = os.path.join(
os.path.dirname(__file__), '..', 'frontend', 'www_static', 'icons',
'favicon-192x192.png')
self._icon_file = io.BytesIO(base64.b64decode(DEFAULT_ICON))

def send_message(self, message="", **kwargs):
"""Send a message to a Android TV device."""
_LOGGER.debug("Sending notification to: %s", self._target)

payload = dict(filename=('icon.png',
open(self._icon_file, 'rb'),
payload = dict(filename=('icon.png', self._icon_file,
'application/octet-stream',
{'Expires': '0'}), type='0',
title=kwargs.get(ATTR_TITLE, ATTR_TITLE_DEFAULT),
Expand All @@ -129,7 +131,7 @@ def send_message(self, message="", **kwargs):
transparency='%i' % TRANSPARENCIES.get(
self._default_transparency),
offset='0', app=ATTR_TITLE_DEFAULT, force='true',
interrupt='%i' % self._default_interrupt)
interrupt='%i' % self._default_interrupt,)

data = kwargs.get(ATTR_DATA)
if data:
Expand Down