Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-mpd2 to v3.1.1 #108143

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

2franix
Copy link
Contributor

@2franix 2franix commented Jan 16, 2024

Proposed change

This is a mere upgrade of the python-mpd2 dependency from v3.0.5 to v3.1.1 to fix #103889

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 16, 2024 12:09
@2franix
Copy link
Contributor Author

2franix commented Jan 16, 2024

Sure, @frenck. I tried to follow the guidelines when submitting my PR but I may have missed to read something. Sorry for that.

Answers to your request

The project maintainer does not publish release notes but here is the changelog
Here is the v3.0.5...v3.1.1 diff

Also

I carefully reviewed the 21 PRs that were merged between those two releases:

Let me know if you need anything else. And most importantly, thank you for your contribution to this project. This is much appreciated!

@2franix 2franix marked this pull request as ready for review January 16, 2024 21:48
@home-assistant home-assistant bot requested a review from frenck January 16, 2024 21:48
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for that swift response @2franix 👍

../Frenck

@frenck frenck merged commit 030b1bc into home-assistant:dev Jan 16, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPD integration may break when MPD service becomes unreachable
2 participants