Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bluetooth device tracker #108513

Closed
wants to merge 1 commit into from

Conversation

xz-dev
Copy link

@xz-dev xz-dev commented Jan 20, 2024

Breaking change

None

Proposed change

Fix: issue #89119

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

return []
_LOGGER.debug("Bluetooth devices discovered = %d", len(result))
return result # type: ignore[no-any-return]
devices = await bluetooth.async_get_scanner(hass).discover()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco
Copy link
Member

bdraco commented Mar 5, 2024

bleak is likely going to be doing a scan for LE devices only so you likely won't see any BR/EDR devices which is what I believe this integration wants. Unless I've missed something, it seems this PR fixes the bluetooth_tracker integration by making it discover LE devices instead of BR/EDR devices.

@emontnemery emontnemery changed the title Fix bluetooth tracker Fix bluetooth device tracker Apr 22, 2024
@emontnemery
Copy link
Contributor

@xz-dev I'm closing this PR since you have not answered the questions by @bdraco. You're welcome to open another PR with the same changes if you still think the changes are useful, in that case please add a reference to this PR from the new PR.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants