Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine recorder and frontend bootstrap step #113985

Merged
merged 7 commits into from
Mar 22, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 22, 2024

Proposed change

The recorder only needs to wait for http and can get set up a little sooner instead of everything waiting in sequence for recorder

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

The recorder only needs to wait for http and
can get set up a little sooner
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco
Copy link
Member Author

bdraco commented Mar 22, 2024

Looks like this will work but there is something leaving files behind that is not mocked and there is a race with the integration platforms

homeassistant/bootstrap.py Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review March 22, 2024 21:47
@bdraco bdraco requested review from a team and raman325 as code owners March 22, 2024 21:47
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Mar 22, 2024
@bdraco
Copy link
Member Author

bdraco commented Mar 22, 2024

retest is good

@bdraco bdraco merged commit 952f47a into dev Mar 22, 2024
35 checks passed
@bdraco bdraco deleted the combine_recorder_frontend branch March 22, 2024 23:50
@bdraco
Copy link
Member Author

bdraco commented Mar 23, 2024

Noticed the test was flapping and that after_deps don't actually work before stage 1 so I fixed them in #114045

bdraco added a commit that referenced this pull request Mar 23, 2024
@bdraco bdraco mentioned this pull request Mar 23, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core integration: recorder Quality Scale: internal small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants