-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Nordic nRF52840 Dongle #114828
Support Nordic nRF52840 Dongle #114828
Conversation
For support Nordic nRF52840 Dongle add zigpy-zboss
For support Nordic nRF52840 Dongle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @e3c6a08b1f15492310b7e2912cc3552b
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ZBOSS radio library right now has no unit tests and isn't compatible with the watchdog changes made to zigpy last year.
I'm afraid I can't approve this PR until the library is:
- Fully unit tested.
- Moved to the zigpy organization.
Merging support for an untested package would introduce an enormous maintenance burden, as we would not be able to update zigpy without also fixing zigpy-zboss and testing it by hand.
Even if ZBoss was more mature, we would still need a discussion if we as Home Assistant want to be responsible for the maintenance of that driver as part of our Home Assistant maintenance. |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: