Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic platform to utility_meter #114967

Merged
merged 5 commits into from
May 14, 2024

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Apr 5, 2024

Breaking change

Proposed change

It is very difficult to debug issues when utility_meters are setup using config_flows

Currently there is an outstanding issue #114547 that requires information on when the next reset is supposed to happen.

This PR will address both situations

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

Would be good to address https://github.com/home-assistant/core/pull/114967/files#r1554723164 before merging

@MartinHjelmare MartinHjelmare changed the title Adds diagnostic platform to utility_meter Add diagnostic platform to utility_meter Apr 8, 2024
@dgomes
Copy link
Contributor Author

dgomes commented May 13, 2024

Look good.

Would be good to address https://github.com/home-assistant/core/pull/114967/files#r1554723164 before merging

I think it's addressed

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgomes 👍

@gjohansson-ST gjohansson-ST merged commit 450c579 into home-assistant:dev May 14, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants