Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Android TV Remote browse media with apps and activity list #117126

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented May 9, 2024

Breaking change

Proposed change

In the configure/options page allow users to provide a mapping: app id <-> app name and icon. Code in config_flow.py and strings.json was copied from the Android Debug Bridge integration and modified to add support for app icon.

androidtv_remote options

Change the media player and remote entities to use that mapping for converting app id to the more readable app name. Also add support for browse media and activity list accordingly to make it easier to launch apps.

androidtv_remote media_player applications androidtv_remote remote activities

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 9, 2024

Hey there @Drafteed, mind taking a look at this pull request as it has been labeled with an integration (androidtv_remote) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of androidtv_remote can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign androidtv_remote Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@tronikos tronikos marked this pull request as ready for review May 9, 2024 05:58
@MartinHjelmare MartinHjelmare changed the title Android TV Remote: Implement source list and activity list Implement Android TV Remote source list and activity list May 9, 2024
@Drafteed
Copy link
Contributor

Drafteed commented May 16, 2024

Personally I'm of the opinion that the list of applications should be stored in the media browser under the Applications section. This is more convenient because it allows you to switch the view of lists and tiles, plus it can also contain application icons.

Here is an example from the Bravia TV integration:

 

The list of sources, in my opinion, should contain a list of device inputs:

 
However, as far as I know, there are no clear standards for this case in HA and some integrations make a list of applications in the list of sources. So it's probably ok.

Anyway it's a good change 👍
I'll try to check it tomorrow.

@tronikos
Copy link
Member Author

I went with how Android Debug Bridge was doing it. I agree that this should be in the apps and not sources for the media player entity. I didn't know that was supported. Do you think you could make the changes? In a future PR if you could also add optional icon in the options flow it would be great.

@tronikos
Copy link
Member Author

I added support for app icons and changed the media player to support browse media.

@tronikos tronikos changed the title Implement Android TV Remote source list and activity list Implement Android TV Remote browse media with apps and activity list May 22, 2024
Copy link
Contributor

@Drafteed Drafteed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 20, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict, could you take a look @tronikos 🙏

../Frenck

@home-assistant home-assistant bot marked this pull request as draft June 21, 2024 14:36
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jun 21, 2024
@tronikos tronikos marked this pull request as ready for review June 21, 2024 17:33
@home-assistant home-assistant bot requested a review from frenck June 21, 2024 17:33
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tronikos 👍

../Frenck

@frenck frenck merged commit ba73885 into home-assistant:dev Jun 21, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
@tronikos tronikos deleted the androidtvremote_activity branch June 23, 2024 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants