-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Android TV Remote browse media with apps and activity list #117126
Conversation
Hey there @Drafteed, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Personally I'm of the opinion that the list of applications should be stored in the media browser under the Here is an example from the Bravia TV integration: The list of sources, in my opinion, should contain a list of device inputs: Anyway it's a good change 👍 |
I went with how Android Debug Bridge was doing it. I agree that this should be in the apps and not sources for the media player entity. I didn't know that was supported. Do you think you could make the changes? In a future PR if you could also add optional icon in the options flow it would be great. |
I added support for app icons and changed the media player to support browse media. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict, could you take a look @tronikos 🙏
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tronikos 👍
../Frenck
Breaking change
Proposed change
In the configure/options page allow users to provide a mapping: app id <-> app name and icon. Code in
config_flow.py
andstrings.json
was copied from the Android Debug Bridge integration and modified to add support for app icon.Change the media player and remote entities to use that mapping for converting app id to the more readable app name. Also add support for browse media and activity list accordingly to make it easier to launch apps.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: