Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSO Energy binary sensors #117174

Merged
merged 11 commits into from
May 29, 2024
Merged

Add OSO Energy binary sensors #117174

merged 11 commits into from
May 29, 2024

Conversation

osohotwateriot
Copy link
Contributor

@osohotwateriot osohotwateriot commented May 10, 2024 •
edited
Loading

Breaking change

Proposed change

Add binary sensors to OSO Energy

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@osohotwateriot osohotwateriot mentioned this pull request May 10, 2024
Merged
8 tasks
davet2001
davet2001 requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @osohotwateriot for contributing!

The PR looks good so far! The description listed that tests had been added, but I didn't see any. If not adding any, please can you update the PR description? Adding tests really helps if you can do that.

I would also recommend adding an icons.json to give a default icon to the new sensors.

.coveragerc Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 12, 2024 19:17
@osohotwateriot osohotwateriot marked this pull request as ready for review May 13, 2024 11:24
@home-assistant home-assistant bot requested a review from davet2001 May 13, 2024 11:24
davet2001
davet2001 previously requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments - sorry for the extra questions - I don't have any way to see what's in the data. If you have some example returned data dicts or a test API that would help.

The main question is around whether device_id includes a unique identifier.

Thanks for adding the icons!

homeassistant/components/osoenergy/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/osoenergy/binary_sensor.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 13, 2024 16:59
@osohotwateriot osohotwateriot marked this pull request as ready for review May 14, 2024 06:48
@home-assistant home-assistant bot requested a review from davet2001 May 14, 2024 06:48
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label May 27, 2024
@home-assistant home-assistant bot marked this pull request as draft May 27, 2024 17:34
@osohotwateriot osohotwateriot marked this pull request as ready for review May 28, 2024 14:26
@home-assistant home-assistant bot requested a review from edenhaus May 28, 2024 14:26
edenhaus
edenhaus approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @osohotwateriot 👍

@edenhaus edenhaus merged commit 1c2cda5 into home-assistant:dev May 29, 2024
24 checks passed
@osohotwateriot osohotwateriot deleted the osoenergy branch May 29, 2024 06:36
raman325 added a commit to raman325/home-assistant that referenced this pull request May 29, 2024
@raman325
Merge branch 'dev' into basic_sensor
8872f2d 
* dev: (8244 commits)
  Update zwave_js WS APIs for provisioning (home-assistant#117400)
  Add OSO Energy binary sensors (home-assistant#117174)
  Add august open action (home-assistant#113795)
  Add smoke detector temperature to Yale Smart Alarm (home-assistant#116306)
  Don't report entities with invalid unique id when loading the entity registry (home-assistant#118290)
  Fix epic_games_store mystery game URL (home-assistant#118314)
  Use runtime_data in ping (home-assistant#118332)
  Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341)
  Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339)
  Improve websocket message coalescing to handle thundering herds better (home-assistant#118268)
  Add cache to more complex entity filters (home-assistant#118344)
  Reduce the intent response data sent to LLMs (home-assistant#118346)
  Small speed up to connecting dispatchers (home-assistant#118342)
  Tweak Assist LLM API prompt (home-assistant#118343)
  Add Conversation command to timers (home-assistant#118325)
  LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283)
  Replace pop calls with del where the result is discarded in entity (home-assistant#118340)
  Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338)
  Use del instead of pop in the entity platform remove (home-assistant#118337)
  Update the recommended model for Google Gen AI (home-assistant#118323)
  ...
raman325 added a commit to raman325/home-assistant that referenced this pull request May 29, 2024
@raman325
Merge branch 'dev' into keys
0b3d33e 
* dev: (1785 commits)
  Update zwave_js WS APIs for provisioning (home-assistant#117400)
  Add OSO Energy binary sensors (home-assistant#117174)
  Add august open action (home-assistant#113795)
  Add smoke detector temperature to Yale Smart Alarm (home-assistant#116306)
  Don't report entities with invalid unique id when loading the entity registry (home-assistant#118290)
  Fix epic_games_store mystery game URL (home-assistant#118314)
  Use runtime_data in ping (home-assistant#118332)
  Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341)
  Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339)
  Improve websocket message coalescing to handle thundering herds better (home-assistant#118268)
  Add cache to more complex entity filters (home-assistant#118344)
  Reduce the intent response data sent to LLMs (home-assistant#118346)
  Small speed up to connecting dispatchers (home-assistant#118342)
  Tweak Assist LLM API prompt (home-assistant#118343)
  Add Conversation command to timers (home-assistant#118325)
  LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283)
  Replace pop calls with del where the result is discarded in entity (home-assistant#118340)
  Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338)
  Use del instead of pop in the entity platform remove (home-assistant#118337)
  Update the recommended model for Google Gen AI (home-assistant#118323)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edenhaus edenhaus edenhaus approved these changes

@davet2001 davet2001 Awaiting requested review from davet2001

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: osoenergy new-feature new-platform Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osohotwateriot @davet2001 @edenhaus @frenck