-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add august open action #113795
Add august open action #113795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Works flawlessly in my fresh dev docker and my yale linus L2. The question is, what if a smart lock only has lock/unlock but no open action |
Hi, when will this be included in the stable version? Thank you! |
There are 2 problems afaik that need to be solved before that:
I'm waiting for feedback on these 2 problems |
Can I somehow integrate this into my system now? Do you perhaps have a hint? It still seems to take a while. Thank you! |
I'm eagerly waiting for it to be merged, too. I can see if it's possible to create a new repo and add the required files to turn It into a HACS compatible Integration. That way it might be easy to add it as custom Repository in HACS, so we can use it that way until this PR gets merged. However, I've never done this before, so not sure if it works. |
could someone please be so kind and help @m10x ? it has been dragging on for two months now and no end in sight :( |
It's on my review list. There are still ~30 PRs ahead of it. Please be patient; there are a lot of people who need help. If the test gets solved before I have a large enough time block to be able to analyze whats needed, I will come back to it sooner as I have much more small time blocks than large ones. |
@coderabbitai review |
WalkthroughThe updates to the Home Assistant Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant HomeAssistant
participant AugustComponent
participant LockDevice
User->>HomeAssistant: Trigger unlock service
HomeAssistant->>AugustComponent: Call async_unlatch
AugustComponent->>LockDevice: Send unlatch command
LockDevice-->>AugustComponent: Acknowledge command
AugustComponent-->>HomeAssistant: Return response
HomeAssistant-->>User: Confirm unlock status
sequenceDiagram
participant TestRunner
participant HomeAssistant
participant AugustComponent
participant MockLockDevice
TestRunner->>HomeAssistant: Run test_open_lock_operation
HomeAssistant->>AugustComponent: Call async_open
AugustComponent->>MockLockDevice: Simulate unlatch command
MockLockDevice-->>AugustComponent: Return mock response
AugustComponent-->>HomeAssistant: Return test result
HomeAssistant-->>TestRunner: Test result
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (6)
Additional comments not posted (11)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@coderabbitai review |
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
tests/components/august/fixtures/get_lock.online_with_unlatch.json
Outdated
Show resolved
Hide resolved
@coderabbitai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Thanks @m10x I took care of anonymizing the test data and adding the missing coverage. |
* dev: (8244 commits) Update zwave_js WS APIs for provisioning (home-assistant#117400) Add OSO Energy binary sensors (home-assistant#117174) Add august open action (home-assistant#113795) Add smoke detector temperature to Yale Smart Alarm (home-assistant#116306) Don't report entities with invalid unique id when loading the entity registry (home-assistant#118290) Fix epic_games_store mystery game URL (home-assistant#118314) Use runtime_data in ping (home-assistant#118332) Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341) Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339) Improve websocket message coalescing to handle thundering herds better (home-assistant#118268) Add cache to more complex entity filters (home-assistant#118344) Reduce the intent response data sent to LLMs (home-assistant#118346) Small speed up to connecting dispatchers (home-assistant#118342) Tweak Assist LLM API prompt (home-assistant#118343) Add Conversation command to timers (home-assistant#118325) LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283) Replace pop calls with del where the result is discarded in entity (home-assistant#118340) Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338) Use del instead of pop in the entity platform remove (home-assistant#118337) Update the recommended model for Google Gen AI (home-assistant#118323) ...
* dev: (1785 commits) Update zwave_js WS APIs for provisioning (home-assistant#117400) Add OSO Energy binary sensors (home-assistant#117174) Add august open action (home-assistant#113795) Add smoke detector temperature to Yale Smart Alarm (home-assistant#116306) Don't report entities with invalid unique id when loading the entity registry (home-assistant#118290) Fix epic_games_store mystery game URL (home-assistant#118314) Use runtime_data in ping (home-assistant#118332) Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341) Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339) Improve websocket message coalescing to handle thundering herds better (home-assistant#118268) Add cache to more complex entity filters (home-assistant#118344) Reduce the intent response data sent to LLMs (home-assistant#118346) Small speed up to connecting dispatchers (home-assistant#118342) Tweak Assist LLM API prompt (home-assistant#118343) Add Conversation command to timers (home-assistant#118325) LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283) Replace pop calls with del where the result is discarded in entity (home-assistant#118340) Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338) Use del instead of pop in the entity platform remove (home-assistant#118337) Update the recommended model for Google Gen AI (home-assistant#118323) ...
Proposed change
Added support for opening locks
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: