-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zwave_js WS APIs for provisioning #117400
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged when frontend PR is ready
* dev: (751 commits) Use runtime_data in ping (home-assistant#118332) Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341) Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339) Improve websocket message coalescing to handle thundering herds better (home-assistant#118268) Add cache to more complex entity filters (home-assistant#118344) Reduce the intent response data sent to LLMs (home-assistant#118346) Small speed up to connecting dispatchers (home-assistant#118342) Tweak Assist LLM API prompt (home-assistant#118343) Add Conversation command to timers (home-assistant#118325) LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283) Replace pop calls with del where the result is discarded in entity (home-assistant#118340) Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338) Use del instead of pop in the entity platform remove (home-assistant#118337) Update the recommended model for Google Gen AI (home-assistant#118323) Fix source_change not triggering an update (home-assistant#118312) Several fixes for the Matter climate platform (home-assistant#118322) Use None default for traccar server battery level sensor (home-assistant#118324) [esphome] 100% voice assistant test coverage (home-assistant#118334) Mark sonos group update a background task (home-assistant#118333) Filter timers more when pausing/unpausing (home-assistant#118331) ...
tested backend and frontend, everything looks good 👍🏾 |
* dev: (8244 commits) Update zwave_js WS APIs for provisioning (home-assistant#117400) Add OSO Energy binary sensors (home-assistant#117174) Add august open action (home-assistant#113795) Add smoke detector temperature to Yale Smart Alarm (home-assistant#116306) Don't report entities with invalid unique id when loading the entity registry (home-assistant#118290) Fix epic_games_store mystery game URL (home-assistant#118314) Use runtime_data in ping (home-assistant#118332) Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341) Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339) Improve websocket message coalescing to handle thundering herds better (home-assistant#118268) Add cache to more complex entity filters (home-assistant#118344) Reduce the intent response data sent to LLMs (home-assistant#118346) Small speed up to connecting dispatchers (home-assistant#118342) Tweak Assist LLM API prompt (home-assistant#118343) Add Conversation command to timers (home-assistant#118325) LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283) Replace pop calls with del where the result is discarded in entity (home-assistant#118340) Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338) Use del instead of pop in the entity platform remove (home-assistant#118337) Update the recommended model for Google Gen AI (home-assistant#118323) ...
* dev: (1785 commits) Update zwave_js WS APIs for provisioning (home-assistant#117400) Add OSO Energy binary sensors (home-assistant#117174) Add august open action (home-assistant#113795) Add smoke detector temperature to Yale Smart Alarm (home-assistant#116306) Don't report entities with invalid unique id when loading the entity registry (home-assistant#118290) Fix epic_games_store mystery game URL (home-assistant#118314) Use runtime_data in ping (home-assistant#118332) Fix last_reported_timestamp not being updated when last_reported is changed (home-assistant#118341) Replace pop calls with del where the result is discarded in restore_state (home-assistant#118339) Improve websocket message coalescing to handle thundering herds better (home-assistant#118268) Add cache to more complex entity filters (home-assistant#118344) Reduce the intent response data sent to LLMs (home-assistant#118346) Small speed up to connecting dispatchers (home-assistant#118342) Tweak Assist LLM API prompt (home-assistant#118343) Add Conversation command to timers (home-assistant#118325) LLM Assist API to ignore intents if not needed for exposed entities or calling device (home-assistant#118283) Replace pop calls with del where the result is discarded in entity (home-assistant#118340) Replace pop calls with del where the result is discarded in mqtt (home-assistant#118338) Use del instead of pop in the entity platform remove (home-assistant#118337) Update the recommended model for Google Gen AI (home-assistant#118323) ...
Breaking change
The websocket APIs for provisioning nodes have changed output and input signatures, primarily switching keys from snake to camel case to be consistent with the zwave-js model.
Proposed change
In #117288 we learned that because we were using
dataclasses.asdict
instead ofZwaveJSDataClass.to_dict()
which resulted in some inconsistent behavior. So we should use to_dict() everywhere, which means changing all of the keys as well to be camel case instead of snake.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: