Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary sensor platform to Teslemetry #117230

Merged
merged 12 commits into from
May 24, 2024

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented May 11, 2024

Proposed change

Add binary sensor platform to Teslemetry

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/teslemetry/strings.json Outdated Show resolved Hide resolved
homeassistant/components/teslemetry/strings.json Outdated Show resolved Hide resolved
homeassistant/components/teslemetry/strings.json Outdated Show resolved Hide resolved
homeassistant/components/teslemetry/strings.json Outdated Show resolved Hide resolved
Copy link
Contributor

@PeteRager PeteRager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 23, 2024 11:34
@Bre77 Bre77 marked this pull request as ready for review May 23, 2024 12:08
tests/components/teslemetry/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/teslemetry/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/teslemetry/coordinator.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 23, 2024 14:06
Bre77 and others added 2 commits May 23, 2024 21:15
@Bre77 Bre77 marked this pull request as ready for review May 23, 2024 21:17
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bre77 👍

@gjohansson-ST gjohansson-ST merged commit ad90ece into home-assistant:dev May 24, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants