Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor asyncio loop protection to improve performance #117295

Merged
merged 5 commits into from
May 12, 2024
Merged

Refactor asyncio loop protection to improve performance #117295

merged 5 commits into from
May 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 12, 2024 •
edited
Loading

Proposed change

Comparing the thread id with get_ident is nearly 2x as fast, and in the common case where the call was allowed, we had to raise an exception to validate there was no running loop which made the implementation even slower.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Refactor asyncio loop protection to improve performance
be6dcf9 
Comparing the thread id with get_ident is nearly 2x as fast,
and in the common case where the call was allowed, we had to
raise an exception which made the implementation even slower.
@bdraco bdraco mentioned this pull request May 12, 2024
Merged
20 tasks
@bdraco
Copy link
Member Author

bdraco commented May 12, 2024

All good on production overnight

@bdraco
Copy link
Member Author

bdraco commented May 12, 2024

thanks

@bdraco bdraco marked this pull request as ready for review May 12, 2024 22:01
@bdraco bdraco requested a review from a team as a code owner May 12, 2024 22:01
@bdraco bdraco merged commit d06932b into dev May 12, 2024
38 checks passed
@bdraco bdraco deleted the faster_protect_loop branch May 12, 2024 22:01
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @balloob