Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to SamsungTV turn-on #117962

Merged
merged 2 commits into from
May 24, 2024
Merged

Add logging to SamsungTV turn-on #117962

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b3742
Add logging to SamsungTV turn-on
epenet May 23, 2024
e25894e
Apply suggestions from code review
epenet May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion homeassistant/components/samsungtv/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from homeassistant.helpers.trigger import PluggableAction
from homeassistant.helpers.update_coordinator import CoordinatorEntity

from .const import CONF_MANUFACTURER, DOMAIN
from .const import CONF_MANUFACTURER, DOMAIN, LOGGER
from .coordinator import SamsungTVDataUpdateCoordinator
from .triggers.turn_on import async_get_turn_on_trigger

Expand Down Expand Up @@ -89,10 +89,21 @@ async def _async_turn_off(self) -> None:
async def _async_turn_on(self) -> None:
"""Turn the remote on."""
if self._turn_on_action:
LOGGER.debug("Attempting to turn on %s via automation", self.entity_id)
await self._turn_on_action.async_run(self.hass, self._context)
elif self._mac:
LOGGER.info(
"Attempting to turn on %s via Wake-On-Lan; if this does not work, "
"please ensure that Wake-On-Lan is available for your device or use "
"a turn_on automation",
self.entity_id,
)
await self.hass.async_add_executor_job(self._wake_on_lan)
else:
LOGGER.error(
"Unable to turn on %s, as it does not have an automation configured",
self.entity_id,
)
raise HomeAssistantError(
f"Entity {self.entity_id} does not support this service."
)