Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add data update coordinator to evohome #118385

Closed
wants to merge 11 commits into from

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented May 29, 2024

Proposed change

This PR prepares evohome for config flow, the intention is for a series of smaller PRs, rather than one large PR.

There are no new features, and no breaking changes. There is no need to update existing documentation.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This PR:

  • adds a data update co-ordinator in coordinator.py and moves the existing Broker there
  • creates const.py and moves many constants there (as they are now shared between modules)
  • adds some typing, mainly Final (for constants)
  • moves some code around in anticipation of upcoming PRs, renames some symbols starting with an underscore

In later PRs, I will split the Broker into Auth and Update components, before adding ConfigFlow.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@edenhaus
Copy link
Contributor

Drafting it as the title specifies as a work in progress.

@edenhaus edenhaus marked this pull request as draft May 29, 2024 14:47
@zxdavb zxdavb changed the title WIP: Add data update coordinator to evohome Add data update coordinator to evohome May 29, 2024
@zxdavb zxdavb marked this pull request as ready for review May 29, 2024 21:13
@zxdavb zxdavb marked this pull request as draft May 30, 2024 07:46
@zxdavb zxdavb changed the title Add data update coordinator to evohome WIP: Add data update coordinator to evohome May 30, 2024
@zxdavb
Copy link
Contributor Author

zxdavb commented May 30, 2024

On hold: will resubmit after #118471 is merged

@zxdavb zxdavb closed this May 31, 2024
@zxdavb zxdavb deleted the evo_coordinator branch May 31, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants