-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate august to use yalexs 5.2.0 #119178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prep work to split the august integration into two integrations as the august and yale global api is diverging related issue #100798
bdraco
changed the title
Migrate august to use yalexs 4.0.0
Migrate august to use yalexs 5.0.1
Jun 9, 2024
bdraco
changed the title
Migrate august to use yalexs 5.0.1
Migrate august to use yalexs 5.1.1
Jun 9, 2024
bdraco
changed the title
Migrate august to use yalexs 5.1.1
Migrate august to use yalexs 5.1.2
Jun 9, 2024
bdraco
changed the title
Migrate august to use yalexs 5.1.2
Migrate august to use yalexs 5.2.0
Jun 9, 2024
frenck
approved these changes
Jun 9, 2024
thanks |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This prep work to split the august integration into two integrations as the august and yale global apis are diverging
There are no expected functional changes (except some bugs that have been fixed in the library). This is only a partial code relocation to avoid duplicating more code than needed. There will need to be a few passes to make the integration as minimal as possible.
related issue #100798
changelog: bdraco/yalexs@v3.2.0...v5.2.0
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: