Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate august to use yalexs 5.2.0 #119178

Merged
merged 11 commits into from
Jun 9, 2024
Merged

Migrate august to use yalexs 5.2.0 #119178

merged 11 commits into from
Jun 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 8, 2024

Proposed change

This prep work to split the august integration into two integrations as the august and yale global apis are diverging

There are no expected functional changes (except some bugs that have been fixed in the library). This is only a partial code relocation to avoid duplicating more code than needed. There will need to be a few passes to make the integration as minimal as possible.

related issue #100798

changelog: bdraco/yalexs@v3.2.0...v5.2.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This prep work to split the august integration into two integrations
as the august and yale global api is diverging

related issue #100798
@bdraco bdraco changed the title Migrate august to use yalexs 4.0.0 Migrate august to use yalexs 5.0.1 Jun 9, 2024
@bdraco bdraco changed the title Migrate august to use yalexs 5.0.1 Migrate august to use yalexs 5.1.1 Jun 9, 2024
@bdraco bdraco changed the title Migrate august to use yalexs 5.1.1 Migrate august to use yalexs 5.1.2 Jun 9, 2024
@bdraco bdraco marked this pull request as ready for review June 9, 2024 02:19
@bdraco bdraco marked this pull request as draft June 9, 2024 03:35
@bdraco bdraco changed the title Migrate august to use yalexs 5.1.2 Migrate august to use yalexs 5.2.0 Jun 9, 2024
@bdraco bdraco marked this pull request as ready for review June 9, 2024 03:41
@frenck frenck merged commit d9f1d40 into dev Jun 9, 2024
38 checks passed
@frenck frenck deleted the yalexs_4 branch June 9, 2024 10:30
@bdraco
Copy link
Member Author

bdraco commented Jun 9, 2024

thanks

bdraco added a commit that referenced this pull request Jun 10, 2024
@bdraco bdraco mentioned this pull request Jun 10, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants