Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tessie for future PR #120406

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Jun 25, 2024

Proposed change

I am going to add another coordinator to each vehicle in a subsequent PR, and am also adding energy coordinators in #118452.

This PR refactors the data model to account for all these new features. Zero functionality has changed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 25, 2024
homeassistant/components/tessie/button.py Outdated Show resolved Hide resolved
homeassistant/components/tessie/button.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 26, 2024 07:53
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@Bre77 Bre77 marked this pull request as ready for review June 26, 2024 09:00
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bre77 👍

@gjohansson-ST gjohansson-ST merged commit d4dc7d7 into home-assistant:dev Jun 26, 2024
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
@Bre77 Bre77 deleted the tessie-prep branch September 23, 2024 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants