-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add homematicip_cloud service set cooling home #121943
Add homematicip_cloud service set cooling home #121943
Conversation
Hey there @hahn-th, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Add set_cooling service, ref: home-assistant/core#121943
Add documentation for set_cooling, refs home-assistant/core#121943
0536aa6
to
a193e84
Compare
Here is the changelog for bumping upstream lib from 1.1.1 to 1.1.2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the rest this seems like it's pretty much good to go 👍
Do I need to do anything or request a review from a core member to merge this? Not sure of the process because it says |
No, me or some other will come by. |
Tnx, see that the PR docs was lonked in the wrong place, but it was here: home-assistant/home-assistant.io#33753 |
I've updated the service/action and updated the docs to reflect this change. Tested this code on my own Homeassistant/Homematic installation and seems to work still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some final remarks/questions 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Test failure not related so will merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @barryvdh 👍
* [homematicip_cloud] Add set_cooling service Add documentation for set_cooling, refs home-assistant/core#121943 * Update source/_integrations/homematicip_cloud.markdown Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update homematicip_cloud.markdown * Rename to set_home_cooling_mode * Update homematicip_cloud.markdown * Update source/_integrations/homematicip_cloud.markdown Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Proposed change
Add a service call to set_cooling_home to set the entire home in Cooling mode (or disable cooling mode to revert to heating). Only works when cooling mode is enabled.
Type of change
Additional information
New release of homematicip-rest-api is here: https://github.com/hahn-th/homematicip-rest-api/releases/tag/1.1.2
It only includes the new set_cooling call.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: