Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homematicip_cloud service set cooling home #121943

Merged

Conversation

barryvdh
Copy link
Contributor

@barryvdh barryvdh commented Jul 14, 2024

Proposed change

Add a service call to set_cooling_home to set the entire home in Cooling mode (or disable cooling mode to revert to heating). Only works when cooling mode is enabled.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

New release of homematicip-rest-api is here: https://github.com/hahn-th/homematicip-rest-api/releases/tag/1.1.2
It only includes the new set_cooling call.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @hahn-th, mind taking a look at this pull request as it has been labeled with an integration (homematicip_cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homematicip_cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homematicip_cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

barryvdh added a commit to barryvdh/home-assistant.io that referenced this pull request Jul 14, 2024
barryvdh added a commit to barryvdh/home-assistant.io that referenced this pull request Jul 14, 2024
@barryvdh
Copy link
Contributor Author

Test failure seems unrelated to this PR. Tests run locally.

Installed repository in custom_modules. Service is available and can be called with true/false and with/without AP, similar to other services:
image

Doc PR: home-assistant/home-assistant.io#33753

@barryvdh barryvdh marked this pull request as ready for review July 14, 2024 17:57
@barryvdh barryvdh force-pushed the feat-homematicip_cloud-set-cooling branch from 0536aa6 to a193e84 Compare July 14, 2024 18:01
@MartinHjelmare MartinHjelmare changed the title [homematicip_cloud] Add service for set cooling home Add homematicip_cloud service set cooling home Jul 14, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 15, 2024
@barryvdh barryvdh requested a review from hahn-th July 15, 2024 13:21
@hahn-th
Copy link
Contributor

hahn-th commented Jul 15, 2024

Here is the changelog for bumping upstream lib from 1.1.1 to 1.1.2:
https://github.com/hahn-th/homematicip-rest-api/blob/master/CHANGELOG.md

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the rest this seems like it's pretty much good to go 👍

homeassistant/components/homematicip_cloud/services.py Outdated Show resolved Hide resolved
@barryvdh
Copy link
Contributor Author

barryvdh commented Aug 5, 2024

Do I need to do anything or request a review from a core member to merge this? Not sure of the process because it says At least 1 approving review is required by reviewers with write access.

@gjohansson-ST
Copy link
Member

Do I need to do anything or request a review from a core member to merge this? Not sure of the process because it says At least 1 approving review is required by reviewers with write access.

No, me or some other will come by.
There is also a documentation PR missing for the feature so please add one and attach it into the PR description.
Undraft this PR when it's ready for review (also considering the comment I just made regarding the service name)

@gjohansson-ST gjohansson-ST marked this pull request as draft August 11, 2024 17:39
@barryvdh
Copy link
Contributor Author

Tnx, see that the PR docs was lonked in the wrong place, but it was here: home-assistant/home-assistant.io#33753
Will update the name to set_home_cooling_mode them and report back.

@barryvdh barryvdh marked this pull request as ready for review August 12, 2024 07:33
@barryvdh
Copy link
Contributor Author

I've updated the service/action and updated the docs to reflect this change. Tested this code on my own Homeassistant/Homematic installation and seems to work still.

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final remarks/questions 👍

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 12, 2024 09:20
@barryvdh barryvdh marked this pull request as ready for review August 12, 2024 11:37
@gjohansson-ST
Copy link
Member

Test failure not related so will merge this PR

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barryvdh 👍

@gjohansson-ST gjohansson-ST merged commit 81faf1b into home-assistant:dev Aug 12, 2024
35 of 36 checks passed
@barryvdh barryvdh deleted the feat-homematicip_cloud-set-cooling branch August 12, 2024 12:02
gjohansson-ST pushed a commit to home-assistant/home-assistant.io that referenced this pull request Aug 12, 2024
* [homematicip_cloud] Add set_cooling service

Add documentation for set_cooling, refs home-assistant/core#121943

* Update source/_integrations/homematicip_cloud.markdown

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update homematicip_cloud.markdown

* Rename to set_home_cooling_mode

* Update homematicip_cloud.markdown

* Update source/_integrations/homematicip_cloud.markdown

Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants