Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wled to 0.19.2 #122101

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Update wled to 0.19.2 #122101

merged 4 commits into from
Jul 18, 2024

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 17, 2024

Breaking change

The WLED integration now requires a WLED device running at least WLED 0.14.0

Proposed change

Updates wled to 0.19.1

Release notes:

Diff: frenck/python-wled@v0.18.0...v0.19.2

This change is rather large, as the upstream library:

  • Has now been put on top of Mashumaro
  • Now requires WLED 0.14.0 or newer
  • Now relies on the light capabilities provided by WLED (which are translated to our color modes in this PR)
  • Separates WLED releases/version check handling from the device logic

These upstream changes have been implemented as minimally as possible in this PR.
Some things could be replaced/made prettier now, but opted to do that later.

In a similar fashion, the upstream library can now make its models more strict (eventually resulting in less if None logic on our end).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@frenck frenck changed the title Update wled to 0.19.1 Update wled to 0.19.2 Jul 18, 2024
frenck and others added 2 commits July 18, 2024 09:37
@frenck
Copy link
Member Author

frenck commented Jul 18, 2024

Thanks, @joostlek 🎉

@frenck frenck merged commit 41d75e1 into dev Jul 18, 2024
36 checks passed
@frenck frenck deleted the frenck-2024-0452 branch July 18, 2024 08:09
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WLED - Traceback with keyerror Cannot add WLED because it supposedly uses CCT
3 participants