-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config_Validation: Added check for domain list #13052
Conversation
* E.g. if 'input_boolean.demo' is either 'input_boolean' or 'remote'
Over in the architecture, this kind of came up already: Do we want users to be able to specify I do understand that there might be a need for combining lights and switches, but I fear this will eventually make the group platforms as "bloated" as the group component has now gotten. I'm open to suggestions. Here are some options I think we could do:
|
I personally would go with option 3, but this PR is more meant to set the fundation to allow for any of those options. |
We can (and should probably) of course move the discussion in the architecture repo. I don't however think that we should do this PR without having a group platform that actually uses it yet. |
@OttoWinter I wouldn't necessarily agree. It is way easier to review just 42 lines of code than a new platform. If we agree that we don't want to limit ourselves to Option #.1, I believe that this would serve as a good basis for new platforms. They will follow, it's just a matter of time (I unfortunately don't have at the moment), like the discussion on the initial PR regarding this: #12592 |
No no, I meant that we should only merge this once another group platform that uses this is created. Maybe there are some things to consider when doing option #.3; Having code around that isn't used anywhere eventually leads to bloat and sometimes the function is even forgotten about. |
Closing this PR for now, until there is a use case for it. |
Description:
Added the option to
entities_domain
to check if entity belongs to one of a list of domains. This could be useful for a futureswitch.group
sinceinput_boolean
andremote
expose some of the same functionality.Checklist:
tox
. Your PR cannot be merged unless tests passIf the code does not interact with devices: