Add electrical measurement sensor to ZHA #14561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 20, 2018
| @property | ||
| def state(self): | ||
| """Return the state of the entity.""" | ||
| if self._state == None: |
There was a problem hiding this comment.
comparison to None should be 'if cond is None:'
fabaff
changed the title
|
Just wanted to comment saying the code changes are working for me, thank you so much :) |
|
Please debase this PR or fix the merge conflict. Thanks in advance! |
dmulcahey
requested review from
cdce8p,
Danielhiversen,
syssi and
a team
as code owners
dmulcahey
force-pushed
the
dm/electrical-sensor
branch
from
96ad0df
to
938cc81
Compare
* add IlluminanceMeasurementSensor * address review comment * Fix whitespace error during merge
dmulcahey
force-pushed
the
dm/electrical-sensor
branch
from
938cc81
to
48e56a8
Compare
Merged
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add sensor that polls electricity usage from devices such as the Samsung smart outlet