-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set cover level using emulated_hue #19594
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
in progress
label
Dec 26, 2018
Looks good, just wondering how this works from a user point of view. What command should you give Alexa (eg) ? |
dgomes
approved these changes
Jan 4, 2019
It behaves like a lamp: |
Thanks for working on this! 👍 |
houndci-bot
reviewed
Jan 11, 2019
dgomes
requested changes
Jan 22, 2019
MartinHjelmare
changed the title
set cover level using emulated_hue
Set cover level using emulated_hue
Jan 23, 2019
houndci-bot
reviewed
Jan 23, 2019
houndci-bot
reviewed
Jan 23, 2019
houndci-bot
reviewed
Jan 23, 2019
@dgomes anything else to fix in your opinion? |
dgomes
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
implemented support to set cover level using emulated_hue.
Added missing tests for cover in emulated_hue component.
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: