Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cover level using emulated_hue #19594

Merged
merged 7 commits into from
Feb 11, 2019
Merged

Set cover level using emulated_hue #19594

merged 7 commits into from
Feb 11, 2019

Conversation

ptc
Copy link
Contributor

@ptc ptc commented Dec 26, 2018

Description:

implemented support to set cover level using emulated_hue.
Added missing tests for cover in emulated_hue component.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@dgomes
Copy link
Contributor

dgomes commented Jan 4, 2019

Looks good,

just wondering how this works from a user point of view. What command should you give Alexa (eg) ?

@ptc
Copy link
Contributor Author

ptc commented Jan 5, 2019

It behaves like a lamp:
Alexa turn off front window (to close)
Alexa turn on front window (to open)
Alexa set front window to 50 percent
Alexa set front window to 20% (only 20% light aka 80% closed)

@andre-richter
Copy link
Contributor

Thanks for working on this! 👍

@MartinHjelmare MartinHjelmare changed the title set cover level using emulated_hue Set cover level using emulated_hue Jan 23, 2019
@ptc
Copy link
Contributor Author

ptc commented Feb 6, 2019

@dgomes anything else to fix in your opinion?

@cgarwood cgarwood merged commit 49ecca9 into home-assistant:dev Feb 11, 2019
@ghost ghost removed the in progress label Feb 11, 2019
@balloob balloob mentioned this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants