Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for relay ports for LCN light platform #19632

Merged
merged 4 commits into from
Jan 20, 2019
Merged

Support for relay ports for LCN light platform #19632

merged 4 commits into from
Jan 20, 2019

Conversation

alengwenus
Copy link
Contributor

@alengwenus alengwenus commented Dec 29, 2018 •
edited
Loading

Description:

Support is added for lights which are connected to the relays of LCN hardware devices.

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7977

Example entry for configuration.yaml (if applicable):

lcn:
  connections:
    - name: myhome
      host: 192.168.2.41
      port: 4114
      username: !secret lcn_username
      password: !secret lcn_password

  lights:
    - name: Living room
      address: myhome.0.7
      output: relay1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost added the in progress label Dec 29, 2018
@alengwenus alengwenus mentioned this pull request Dec 29, 2018
Merged
2 tasks
dgomes
dgomes requested changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@dgomes dgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

homeassistant/components/lcn.py Show resolved Hide resolved
homeassistant/components/lcn.py Show resolved Hide resolved
homeassistant/components/light/lcn.py Outdated Show resolved Hide resolved
MartinHjelmare
MartinHjelmare approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@MartinHjelmare MartinHjelmare merged commit a8d3a90 into home-assistant:dev Jan 20, 2019
@ghost ghost removed the Ready for review label Jan 20, 2019
alengwenus added a commit to alengwenus/home-assistant-core that referenced this pull request Jan 20, 2019
@alengwenus
Revert "Support for relay ports for LCN light platform (home-assistan…
101d4cb 
…t#19632)"

This reverts commit a8d3a90.
@alengwenus alengwenus deleted the dev_lcn_relaylights branch January 20, 2019 18:23
alengwenus added a commit to alengwenus/home-assistant-core that referenced this pull request Jan 21, 2019
@alengwenus
Revert "Support for relay ports for LCN light platform (home-assistan…
57f4d52 
…t#19632)"

This reverts commit a8d3a90.
@balloob balloob mentioned this pull request Feb 6, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
@alengwenus @alandtse
Support for relay ports for LCN light platform (home-assistant#19632)
87150f6 
* Added relay ports to LCN lights platform

* Exchanged validation for ports with uppercase validator. Makes interfacing with pypck enums much more simple.

* Removed supported_features property as it is correctly inherited from parent

* Removed type annotations.
kellerza pushed a commit to kellerza/home-assistant that referenced this pull request Feb 24, 2019
@alengwenus @kellerza
Support for relay ports for LCN light platform (home-assistant#19632)
24e297f 
* Added relay ports to LCN lights platform

* Exchanged validation for ports with uppercase validator. Makes interfacing with pypck enums much more simple.

* Removed supported_features property as it is correctly inherited from parent

* Removed type annotations.
@ghost ghost removed the platform: light.lcn label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@dgomes dgomes dgomes approved these changes

Assignees
No one assigned
Labels
cla-signed integration: lcn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alengwenus @dgomes @MartinHjelmare @homeassistant