Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow embedded platforms #19948

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Allow embedded platforms #19948

merged 2 commits into from
Jan 11, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 11, 2019

Description:

Allow specifying platforms under components itself. Applied to Hue to show how it will look.

Backwards compatible.

For some components, it will be a bit more work than just a rename and changing import, depending on if they use "patch" in their tests.

Related issue (if applicable): fixes home-assistant/architecture#124

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner January 11, 2019 00:08
@ghost ghost assigned balloob Jan 11, 2019
@ghost ghost added the in progress label Jan 11, 2019
@OttoWinter
Copy link
Member

Unintended consequence: The light.switch platform will also be available as switch.light but not really an issue tho.

@balloob
Copy link
Member Author

balloob commented Jan 11, 2019

Yeah that's temporarily, it will be fine. And funnily, that might still work too 😉

@balloob balloob merged commit a8f2228 into dev Jan 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the embedded-platforms branch January 11, 2019 19:30
@ghost ghost removed the in progress label Jan 11, 2019
@OttoWinter OttoWinter mentioned this pull request Jan 14, 2019
2 tasks
evanjd added a commit to evanjd/home-assistant that referenced this pull request Jan 18, 2019
@balloob balloob mentioned this pull request Jan 23, 2019
@marthoc marthoc mentioned this pull request Jan 27, 2019
marthoc added a commit to marthoc/kuna that referenced this pull request Jan 27, 2019
Refactor custom component to take advantage of embedded platforms. Leverages home-assistant/core#19948 to make installing and updating this custom component much easier (using git!).
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
* Allow embedded platforms

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded platforms and the road to packaged components
3 participants